Skip to content

dont hardcode VERIFY_WEIGHTS - #2823

Merged
knightwh merged 1 commit into
atwigg/mlperffrom
andytwigg-patch-8
Oct 12, 2026
Merged

knightwh merged 1 commit into
atwigg/mlperffrom
andytwigg-patch-8

Conversation

@andytwigg

Copy link
Copy Markdown
Collaborator

Resolves #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

Reference

Colab Notebook

Checklist

  • I have added all the necessary unit tests for my change.
  • I have verified that my change does not break existing code and all unit tests pass.
  • I have added all appropriate doc-strings/documentation.
  • My PR is based on the latest changes of the main branch (if unsure, rebase the code).
  • I have signed the Contributor License Agreement.
  • I have followed Contribution Guidelines.

Note: Standard CPU unit tests, package builds, and documentation checks run automatically on all pull requests. Multi-device TPU integration tests (tunix_tpu_unit_tests) run automatically on Copybara-synced pull requests and pull requests targeting atwigg/mlperf (and are triggered by maintainers after review for external fork pull requests).

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves configuration flexibility by allowing the VERIFY_WEIGHTS setting to be controlled via environment variables. By implementing a default value pattern, it ensures backward compatibility while enabling users to override the behavior as needed.

Highlights

  • Configuration Flexibility: Updated the VERIFY_WEIGHTS environment variable to support external overrides while maintaining a default value of 'true'.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the 'mlperf_base.sh' recipe to make the 'VERIFY_WEIGHTS' environment variable configurable, defaulting to 'true' if it is not already set. There are no review comments, and I have no additional feedback to provide.

@knightwh
knightwh merged commit 92f2f57 into atwigg/mlperf Oct 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants