Repository navigation
fix: preserve data when parsing headerless CSV - #144
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CsvToTable(..., header=False)discards the first data row and does not populate the generated header: assigning a dictionary to an empty Row'svaluesonly updates existing keys. A second row then fails with a length mismatch.Create the numeric header entries explicitly and let the first line proceed through the normal row-append path. Also keep the header's row number at zero instead of overwriting it for every data row;
NewRow()already assigns the correct data-row number.Tests cover one-row and multiple-row inputs, comments, text and byte streams, and row numbering in both header modes. The new cases fail before the fix. All 103 tests pass afterward;
git diff --checkpasses.