Repository navigation
fix: stop CSV header scanning at end of input - #142
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CsvToTablerepeatedly callsreadline()while looking for a nonempty header, but never detects EOF. Empty, blank-only, and comment-only input therefore hangs indefinitely.Return an empty reset table when EOF arrives before a header. Nonempty CSV parsing is unchanged. Regression coverage includes both text and byte streams and reusing a previously populated table.
Validation: the old implementation was terminated after a one-second subprocess timeout on empty input. All 102 tests pass after the fix, including six empty-input subcases;
git diff --checkpasses. Existing regex FutureWarnings remain unchanged.