Repository navigation
Avoid unconditional spinlock bounce in AllocationSampleList::ReportMalloc. - #1328
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_995150742
branch
from
October 12, 2026 09:21
aae83bd to
3646410
Compare
copybara-service
Bot
changed the title
copybara-service
Bot
force-pushed
the
test_995150742
branch
from
October 12, 2026 20:53
3646410 to
d578cb1
Compare
…lloc. Previously, `AllocationSampleList::ReportMalloc` unconditionally acquired the global `AllocationSampleList::lock_` spinlock on every sampled allocation in `SampleifyAllocation`, even when no `AllocationSample` profiler was active (`first_ == nullptr`). Make `first_` a `std::atomic<AllocationSample* absl_nullable>` and check `first_.load(std::memory_order_acquire) == nullptr` before acquiring `lock_`, matching `DeallocationProfilerList::ReportMalloc`. PiperOrigin-RevId: 995150742
copybara-service
Bot
force-pushed
the
test_995150742
branch
from
October 12, 2026 22:07
d578cb1 to
ad09bfa
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid unconditional spinlock bounce in AllocationSampleList::ReportMalloc.
Previously,
AllocationSampleList::ReportMallocunconditionally acquired the globalAllocationSampleList::lock_spinlock on every sampled allocation inSampleifyAllocation, even when noAllocationSampleprofiler was active (first_ == nullptr).Make
first_astd::atomic<AllocationSample* absl_nullable>and checkfirst_.load(std::memory_order_acquire) == nullptrbefore acquiringlock_, matchingDeallocationProfilerList::ReportMalloc.