Repository navigation
Batch Span::Delete in StaticForwarder::DeallocateSpans - #1325
Merged
Merged
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
copybara-service
Bot
force-pushed
the
test_995150925
branch
5 times, most recently
from
October 12, 2026 20:12
b8250e5 to
4b5c3ed
Compare
Add absl::Span<T* absl_nonnull> batch overload to MetadataObjectAllocator::Delete and absl::Span<Span* absl_nonnull> overload to Span::Delete, and call Span::Delete(free_spans) once in StaticForwarder::DeallocateSpans instead of acquiring and releasing metadata_lock_ on every individual span in the loop. PiperOrigin-RevId: 998146855
copybara-service
Bot
force-pushed
the
test_995150925
branch
from
October 12, 2026 21:14
4b5c3ed to
3bafb04
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch Span::Delete in StaticForwarder::DeallocateSpans
Add absl::Span<T* absl_nonnull> batch overload to MetadataObjectAllocator::Delete and absl::Span<Span* absl_nonnull> overload to Span::Delete, and call Span::Delete(free_spans) once in StaticForwarder::DeallocateSpans instead of acquiring and releasing metadata_lock_ on every individual span in the loop.