Skip to content

refactor: improve datastore repo index batch get error handling #5537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
another-rex wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −3
Open

refactor: improve datastore repo index batch get error handling #5537

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions go/internal/database/datastore/repo_index.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,10 +116,17 @@ func (s *RepoIndexStore) GetRepoIndexes(ctx context.Context, ids []string) ([]*m
dbIndexes := make([]*RepoIndex, len(ids))
err := s.client.GetMulti(ctx, keys, dbIndexes)
if err != nil {
// If some entities are not found, GetMulti returns datastore.ErrMultiErr
var multiErr datastore.MultiError
if !errors.As(err, &multiErr) {
return nil, fmt.Errorf("failed to batch get RepoIndexes: %w", err)
if errors.As(err, &multiErr) {
for i, e := range multiErr {
if errors.Is(e, datastore.ErrNoSuchEntity) {
dbIndexes[i] = nil
} else if e != nil {
return nil, fmt.Errorf("failed to get multi: %w", err)
}
}
} else {
return nil, fmt.Errorf("failed to get multi: %w", err)
}
}

Expand Down
Loading