syscalls: prevent overwriting currently executing binary - #14164
Closed
Rajkaran-122 wants to merge 2 commits into
Closed
syscalls: prevent overwriting currently executing binary#14164Rajkaran-122 wants to merge 2 commits into
Rajkaran-122 wants to merge 2 commits into
Conversation
Add ETXTBSY check in renameat to prevent renaming the currently executing binary. This implements basic Linux behavior where attempting to overwrite a running executable fails with ETXTBSY error. This is a partial implementation of ETXTBSY behavior as requested in google#1005, preventing modification of the executable file itself while it's running.
milantracy
requested changes
Aug 18, 2026
| exe := t.MemoryManager().Executable() | ||
| if exe != nil { | ||
| // Check if the source file is the current executable. | ||
| oldVD, err := t.Kernel().VFS().FindFileDescription(t, oldtpop.pop) |
Collaborator
There was a problem hiding this comment.
VirtualFilesystem has no FindFileDescription method
…FileDescription The previous implementation used VirtualFilesystem.FindFileDescription which does not exist. Changed to use VirtualFilesystem.OpenAt which is the correct method to get a FileDescription from a PathOperation. This fixes the build error reported in PR google#14164.
milantracy
requested changes
Aug 19, 2026
milantracy
left a comment
milantracy
left a comment
Collaborator
There was a problem hiding this comment.
the PR is not acceptable, and i have no idea what the PR wants to fix
- Linux doesn't return ETXTBSY on rename.
- #1005 is about a different path, renameat isn't involved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ETXTBSY check in renameat to prevent renaming the currently executing binary. This implements basic Linux behavior where attempting to overwrite a running executable fails with ETXTBSY error.
This is a partial implementation of ETXTBSY behavior as requested in #1005, preventing modification of the executable file itself while it's running.