Add cache for map icons - #3884
Open
andreia-ferreira wants to merge 4 commits into
Open
Conversation
andreia-ferreira
requested a deployment
to
e2e-approval
August 14, 2026 09:10 — with 
GitHub Actions
Waiting
GitHub Actions
Waiting
andreia-ferreira
changed the title
| } | ||
|
|
||
| private val clusterIcons = | ||
| object : LruCache<String, BitmapDescriptor>(1) { |
Member
There was a problem hiding this comment.
nit: Can we increase the default to 16 as well?
shobhitagarwal1612
approved these changes
Aug 15, 2026
shobhitagarwal1612
left a comment
shobhitagarwal1612
left a comment
Member
There was a problem hiding this comment.
Nice improvements! 👏 👏 👏
Left a minor comment for your consideration. Please feel free to ignore if you disagree with the suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3866
Every icon was rebuilt from scratch (cluster icons and regular marker icons) on panning and zooming the map. On large surveys this could cause the map performance to drop significantly and also lead to OOM crashes due to memory pressure.
This PR introduces a cache for both clusters and marker icons.
The impact of these changes can be seen in the heap dump comparison of before/after.
Before:
After:
@shobhitagarwal1612 PTAL?