Repository navigation
[Swift] Import WASILibc instead of Foundation on WASI in FlatBuffers - #9461
Open
AttilaTheFun wants to merge 1 commit into
Open
AttilaTheFun wants to merge 1 commit into
AttilaTheFun wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
AttilaTheFun
force-pushed
the
swift-wasi-without-foundation
branch
from
November 4, 2026 16:17
e5fe157 to
dda4e9e
Compare
AttilaTheFun
marked this pull request as ready for review
November 5, 2026 00:13
logan-shire-claude Bot
added a commit
to AttilaTheFun/bazel_registry
that referenced
this pull request
Nov 5, 2026
Upstream's 25.12.19 with three patches: - **Dev-only dependencies:** its JavaScript, TypeScript, Go and gRPC dependencies, and its npm and node extensions, become `dev_dependency`. flatc and the Swift runtime use none of them, and gRPC brought a rules_foreign_cc that doesn't load under Bazel 9, which every consumer had to override. - **No Foundation on WASI** (google/flatbuffers#9461). - **The Swift BUILD glob's missing `Vectors/`** (upstream #8875, merged; not in a release yet). As a version, it takes the place of the root-only `single_version_override` with two patches (and rules_foreign_cc's) that every isomer consumer repeated. Built from a local checkout of this entry: isomer's renderer and Foundation targets, and the examples' web and Android Storybooks. Co-authored-by: Claude <344224626+logan-shire-claude[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FlatBuffers and Common sources already keep every Foundation use behind
#if !os(WASI)but stillimport Foundationthere, which pulls Foundation into WASI builds that use none of it. On WASI they now import WASILibc. FlexBuffers is unchanged.Tested:
tests/swift/Wasm.testsunder wasmtime with no Foundation in FlatBuffers' or Common's dependencies;swift build --target FlatBufferson Linux.