Skip to content

Use clusterfuzz_manifest.json to set ChromeBuildArchive#5351

Open
notvictorl wants to merge 2 commits into
google:masterfrom
notvictorl:liuvic/manifest
Open

Use clusterfuzz_manifest.json to set ChromeBuildArchive#5351
notvictorl wants to merge 2 commits into
google:masterfrom
notvictorl:liuvic/manifest

Conversation

@notvictorl

@notvictorl notvictorl commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

Chrome build archives using archive schema v1 don't have args.gn at the root of the zip, so they are run as DefaultBuildArchive instead of ChromeBuildArchive. This leads to them not utilizing clusterfuzz_manifest.json later in the run, and in turn, waste time running run_*_fuzzer binaries.

Adding clusterfuzz_manifest.json to the heuristic used to categorize ChromeBuildArchive in open_with_reader() since only Chrome archives create and include this file. Adding unit tests to help test this section.

Bug: https://crbug.com/507833074

@notvictorl notvictorl requested a review from a team as a code owner July 6, 2026 14:59
@notvictorl notvictorl requested a review from letitz July 6, 2026 15:36

@letitz letitz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Comment thread src/clusterfuzz/_internal/build_management/build_archive.py Outdated
Co-authored-by: Titouan Rigoudy <titouan.rigoudy@gmail.com>
@notvictorl notvictorl requested a review from javanlacerda July 6, 2026 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants