Use clusterfuzz_manifest.json to set ChromeBuildArchive#5351
Open
notvictorl wants to merge 2 commits into
Open
Use clusterfuzz_manifest.json to set ChromeBuildArchive#5351notvictorl wants to merge 2 commits into
notvictorl wants to merge 2 commits into
Conversation
letitz
approved these changes
Jul 6, 2026
Co-authored-by: Titouan Rigoudy <titouan.rigoudy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Chrome build archives using archive schema v1 don't have
args.gnat the root of the zip, so they are run asDefaultBuildArchiveinstead ofChromeBuildArchive. This leads to them not utilizingclusterfuzz_manifest.jsonlater in the run, and in turn, waste time runningrun_*_fuzzerbinaries.Adding
clusterfuzz_manifest.jsonto the heuristic used to categorizeChromeBuildArchiveinopen_with_reader()since only Chrome archives create and include this file. Adding unit tests to help test this section.Bug: https://crbug.com/507833074