Fix similarity score for binaries without flow graph edges - #91
Open
zunnurawan wants to merge 1 commit into
Open
zunnurawan wants to merge 1 commit into
zunnurawan wants to merge 1 commit into
Conversation
When neither binary has any flow graph edges, the edge term of the program similarity score evaluated to 0, capping the score at 0.65 even for a self-diff. Instead, treat this as full match, since there is no disagreement. Fixes google#90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When neither binary has any flow graph edges, the edge term of the program similarity score evaluated to 0, capping the score at 0.65 even for a self-diff. Instead, treat this as full match, since there is no disagreement.
Fixes #90
Verified with the
no_jumpssample from the issue: self-diff similarity goes from 64.565% to 99.3307% (1.0 × confidence). Diffs of binaries that have edges are unaffected.