Conversation
Author
|
@dmah42 tagging for visibility :) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run on (24 X 4700 MHz CPU s)reports the machine CPU's count, so a benchmark restricted withtaskset -c 0gives no indication that the restriction took effect.So as discussed in the related issue, we decided to add a new field to
CPUInfo,num_cpus_in_affinity_mask(0 when it cannot be determined, e.g. macOS), using the same path used inThreadAffinityGuard.Now the console reporter appends
, N in affinity maskonly when N < num_cpus, so the output is unchanged when a restriction is not applied. On the other hand, the JSON reporter emits the field as well, whenever it is known, next tonum_cpus.I ran all the tests and everything passes as expected.
Fixes #1812