Skip to content

Support configurable emulator screen resolution#225

Closed
jnhyperion wants to merge 3 commits into
google:masterfrom
jnhyperion:configurable-emulator-screen-resolution
Closed

Support configurable emulator screen resolution#225
jnhyperion wants to merge 3 commits into
google:masterfrom
jnhyperion:configurable-emulator-screen-resolution

Conversation

@jnhyperion
Copy link
Copy Markdown

Added emulator screen resolution configuration options in interactive mode.

image

Copy link
Copy Markdown
Contributor

@pokowaka pokowaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

@jnhyperion
Copy link
Copy Markdown
Author

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
    OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

@pokowaka
Copy link
Copy Markdown
Contributor

  • Would you mind moving the UI pieces to emu_downloads_menu.py?
    OK.
  • Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.

I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:

  1. user could have some requests of customized devices, they have various width/height/dpi, we can not list all the hardware profile
  2. Pixel2 is hard coded in many code pieces, make it a variable will have many modifications

What do you think?

You are absolutely right. I should have prefixed it with would you like us to make those changes (different device profiles)

@jnhyperion
Copy link
Copy Markdown
Author

@pokowaka sure, it would be great.

@jpcottin
Copy link
Copy Markdown
Collaborator

@jnhyperion — thanks for the contribution, and apologies it sat without action for so long. Closing rather than asking for a rebase because the right path forward looks different from the implementation here:

  • The diff patches emu/templates/avd/Pixel2.avd/config.ini, which was renamed to MediumPhone.avd/config.ini in templates: rename the AVD from Pixel2 to MediumPhone #402 (merged today) — so a mechanical rebase can't recover that file.
  • The non-interactive emu-docker create (which most automation uses) wouldn't get the feature with the current shape; a CLI flag like --screen-resolution WxHxDPI usable from both flows would be more broadly useful, and wouldn't need the new consolemenu dependency.
  • A few unrelated changes (iputils-ping install, commented-out EXPOSE 5554 / EXPOSE 8554 — those ports are actively used) would need to be split out separately.

If configurable resolution is still useful to you, please open a new issue describing the feature request — a CLI-flag-based approach usable from both the scripted and interactive flows. Small enough that anyone (including a fresh attempt by you) could pick it up.

The code and instructions have changed substantially since this was filed, so a fresh thread will be easier to track.

@jpcottin jpcottin closed this May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants