Support configurable emulator screen resolution#225
Conversation
pokowaka
left a comment
There was a problem hiding this comment.
- Would you mind moving the UI pieces to emu_downloads_menu.py?
- Would it be useful to have a set of default devices? (Pixel2, Pixel3, etc?) right now we have no way of specifying width/height/dpi from commandline.
I thought about it before, there are 2 reasons why I prefer to enter width/height/dpi from command line:
What do you think? |
You are absolutely right. I should have prefixed it with would you like us to make those changes (different device profiles) |
|
@pokowaka sure, it would be great. |
|
@jnhyperion — thanks for the contribution, and apologies it sat without action for so long. Closing rather than asking for a rebase because the right path forward looks different from the implementation here:
If configurable resolution is still useful to you, please open a new issue describing the feature request — a CLI-flag-based approach usable from both the scripted and interactive flows. Small enough that anyone (including a fresh attempt by you) could pick it up. The code and instructions have changed substantially since this was filed, so a fresh thread will be easier to track. |
Added emulator screen resolution configuration options in interactive mode.