Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
rohityan
added
the
request clarification
after_tool_callback logged every tool result as TOOL_COMPLETED with status OK, including MCP CallToolResult isError payloads and results that carry error_details. Classify those as TOOL_ERROR so status and error_message match on_tool_error_callback. Fixes google#7112 Co-authored-by: Zsanz3 <Zsanz3@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/bqaa-tool-error-result-241d
branch
from
September 15, 2026 22:30
4713972 to
dd3206b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7112
Summary
BigQueryAgentAnalyticsPlugin.after_tool_callbackwas logging error-bearing tool results asTOOL_COMPLETED/ OK. It now classifies results withisError/error_detailsasTOOL_ERROR(aligned withon_tool_error_callback).Changes
error_details,isError/is_error; prefer MCPcontent[0].textforerror_messagewhen present_log_eventcovering MCPisErroranderror_detailsTests