fix(openapi): omit header and cookie params the model leaves null - #7099
Open
Kumaresan-AI-Engineer wants to merge 1 commit into
Open
Kumaresan-AI-Engineer wants to merge 1 commit into
Kumaresan-AI-Engineer wants to merge 1 commit into
Conversation
A model routinely emits null for an optional parameter it decided not to use. _prepare_request_params already drops such a value for a query parameter, but passed it through for header and cookie parameters: - httpx refuses to encode a None header value, so the whole tool call fails with "Header value must be str or bytes, not <class 'NoneType'>" before the request is ever sent, and the model gets no usable error to recover from. - httpx accepts a None cookie and serializes it as a bare, valueless `Cookie: <name>` pair, so the request goes out malformed and silently. Skip both when the value is None, matching how an unset query parameter is already handled in the same loop. An explicitly empty string is still sent, so a caller can keep passing a deliberate empty value.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A model routinely emits null for an optional parameter it decided not to use. _prepare_request_params already drops such a value for a query parameter, but passed it through for header and cookie parameters:
Cookie: <name>pair, so the request goes out malformed and silently.Skip both when the value is None, matching how an unset query parameter is already handled in the same loop. An explicitly empty string is still sent, so a caller can keep passing a deliberate empty value.