fix(cli): point to Gemini Enterprise registration docs after agent_engine deploy - #6634
Open
chelsealong wants to merge 1 commit into
Open
fix(cli): point to Gemini Enterprise registration docs after agent_engine deploy#6634chelsealong wants to merge 1 commit into
chelsealong wants to merge 1 commit into
Conversation
…gine deploy Fixes google#6633 adk deploy agent_engine has no way to push directly to Gemini Enterprise, and users had no indication of how to make a deployed agent available there. Print a pointer to the registration docs after a successful deploy, matching the doc link already used by the --gemini_enterprise_app_name flag on `adk api_server`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6633
Problem
adk deploy agent_enginehas no way to push directly to GeminiEnterprise, and after a successful deploy there was no indication of
how to make the agent available there. The issue's proposed
alternative was for
adk deployto at least tell users how to do it.Fix
After a successful
adk deploy agent_engine, print a pointer to theGemini Enterprise registration docs
(
https://docs.cloud.google.com/gemini/enterprise/docs/register-and-manage-an-adk-agent),reusing the same doc link already referenced by the
--gemini_enterprise_app_nameflag onadk api_server.This is a minimal, additive change: no new deploy target, no new
auth/credential handling, just a helpful hint printed alongside the
existing "Deployed to Agent Platform" / playground URL messages in
src/google/adk/cli/cli_deploy.py.Testing plan
Added
test_print_gemini_enterprise_hintintests/unittests/cli/utils/test_cli_deploy.py, mirroring the existingtest_print_agent_engine_urltest.Verified the test fails without the fix (checked out the pre-fix
version of
cli_deploy.pyand reran):With the fix applied, the full deploy test file passes:
Also ran
pyink --checkandisort --checkon both changed fileswith no diffs.
AI assistance disclosure
This change was developed with the help of an AI coding agent (Claude
Code), including drafting the fix, the test, and this description. All
changes were reviewed and verified locally before submission.