fix(tests): skip bash tool tests on Windows#5680
Open
danyalahmed1995 wants to merge 5 commits into
Open
Conversation
Skips `test_bash_tool.py` at module level on Windows because it imports Python's Unix-only `resource` module during collection. Validation: - `python -m pytest tests/unittests/tools/test_bash_tool.py -q` - `python -m pytest tests/unittests/platform -q` - `python -m pytest tests/unittests/utils/test_env_utils.py -q` - `git diff --check`
rohityan
added
tools
Collaborator
|
Hi @danyalahmed1995 ,Thank you for your contribution! We appreciate you taking the time to submit this pull request. Can you please fix the failing pre-commit test by running autoformat.sh. |
Author
|
@rohityan Thanks, I ran the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes Windows test collection for
tests/unittests/tools/test_bash_tool.py.The test module imports Python's
resourcemodule at import time, butresourceis Unix-only and unavailable on Windows. As a result, running the targeted test on Windows fails during collection before pytest can report a skip.This change adds a module-level Windows skip before importing
resource.Validation
Ran on Windows 10 with Python 3.12:
python -m pytest tests/unittests/tools/test_bash_tool.py -qpython -m pytest tests/unittests/platform -qpython -m pytest tests/unittests/utils/test_env_utils.py -q