Repository navigation
Drop token refresh responses for a replaced authorization - #653
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses an issue where an in-flight token refresh could overwrite newer tokens if scopes were added concurrently. In GIDGoogleUser.m, the refresh response is now dropped if the authorization has been replaced while the request was in flight. A corresponding unit test has been added to verify this behavior, and the changelog has been updated. There are no review comments to evaluate, and the implementation is clean and well-tested, so I have no feedback to provide.
w-goog
force-pushed
the
fix/googleuser-drop-stale-refresh
branch
from
October 15, 2026 22:40
60305f3 to
232d7b3
Compare
w-goog
added this pull request to stack #654
October 15, 2026 22:48
w-goog
force-pushed
the
fix/googleuser-drop-stale-refresh
branch
from
October 15, 2026 23:11
232d7b3 to
c2b11ef
Compare
w-goog
force-pushed
the
fix/googleuser-drop-stale-refresh
branch
2 times, most recently
from
October 19, 2026 20:18
e64ca1a to
f9b06a5
Compare
yalkhder
approved these changes
Oct 19, 2026
w-goog
force-pushed
the
fix/googleuser-drop-stale-refresh
branch
2 times, most recently
from
October 20, 2026 16:41
e49940c to
5b9550d
Compare
w-goog
force-pushed
the
fix/googleuser-drop-stale-refresh
branch
from
October 20, 2026 16:46
5b9550d to
a858c93
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
addScopescould overwrite the newer tokens with stale ones (grantedScopesandaccessTokenreverted to their pre-add-scopes values).addScopesupdate.