Fix/increment headers sequential suffix - #1
Merged
Merged
Conversation
Phase 0 housekeeping: - Upgrade actions/checkout and actions/cache to v4 - Test on PHP 8.2–8.5 - Remove Scrutinizer coverage upload - Fail the suite on test errors (no continue-on-error) Co-authored-by: Janez Urevc <janez@example.com>
Declare php ^8.2, lock-aware validate/install, cache key includes lock, --no-interaction.
- Replace dead Travis/Scrutinizer badges with GitHub Actions - Note supported PHP versions - Point docs links at readthedocs.io - Remove .scrutinizer.yml (coverage no longer uploaded)
- Align composer.json support.docs with readthedocs.io - Drop stale .scrutinizer.yml / .travis.yml export-ignore entries - Clarify PHP badge wording on core (tested in CI)
Update README CI badges and drop Scrutinizer
Breaking major: drop PHP < 8.2 and portphp 1.x. Add Dependabot and UPGRADE-3.0.md.
Release 3.0.0: PHP ^8.2 and portphp/portphp ^2.0
Bumps [actions/cache](https://github.com/actions/cache) from 4 to 6. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v4...v6) --- updated-dependencies: - dependency-name: actions/cache dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 7. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4...v7) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…actions/checkout-7 Bump actions/checkout from 4 to 7
…actions/cache-6 Bump actions/cache from 4 to 6
PHP 8.4 deprecates fputcsv() calls that omit the $escape argument. Add an optional constructor parameter (default '\\' for BC) and pass it through to fputcsv so callers can silence the deprecation and control escape behavior (including empty string for modern "no escape" CSV). Adds PHPUnit coverage that proves escape is applied and that writing works without deprecation exceptions under convertDeprecationsToExceptions. Supersedes portphp#10.
Supersedes portphp#3 with regression tests.
array_count_values() groups every occurrence of a repeated header together in the output, based on that header's first-appearance order in the input - not the position it actually appeared at. For headers like ['a', 'b', 'a', 'c'] this produces ['a', 'a1', 'b', 'c'], which no longer lines up column-for-column with the CSV row's actual values at those same indexes. Walk $headers in original order instead, incrementing a per-header counter as each duplicate is encountered, so the incremented headers array stays positionally aligned with the row data: ['a', 'b', 'a1', 'c'].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.