Skip to content

let checkout-api raise error on confirm for sync #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wcole1-godaddy merged 1 commit into from
May 29, 2026
Merged

let checkout-api raise error on confirm for sync #1381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-missing-shipping-info-error.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@godaddy/react": patch
---

Return the missing shipping info error when checkout is blocked by absent shipping lines or fulfillment.
4 changes: 2 additions & 2 deletions packages/react/src/components/checkout/payment/utils/use-confirm-checkout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ export function useConfirmCheckout() {
isShipping &&
(!hasShippingLines || hasLineItemsMissingShippingFulfillment)
) {
setCheckoutErrors(['SHIPPING_METHOD_APPLICATION_FAILED']);
throw new Error('SHIPPING_METHOD_APPLICATION_FAILED');
setCheckoutErrors(['MISSING_SHIPPING_INFO']);
throw new Error('MISSING_SHIPPING_INFO');
}

const pickUpData = isPickup
Expand Down
12 changes: 1 addition & 11 deletions packages/react/src/components/checkout/shipping/shipping-method.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ export function ShippingMethodForm() {
const formatCurrency = useFormatCurrency();
const form = useFormContext();
const { t } = useGoDaddyContext();
const { session, isConfirmingCheckout, setCheckoutErrors } =
useCheckoutContext();
const { session, isConfirmingCheckout } = useCheckoutContext();
const updateTaxes = useUpdateTaxes();
const queryClient = useQueryClient();
const isPaymentDisabled = useIsPaymentDisabled();
Expand Down Expand Up @@ -205,14 +204,6 @@ export function ShippingMethodForm() {
queryKey: ['draft-order', session.id],
});
},
onError: () => {
if (!isFulfillmentSync || !session?.id) return;

setCheckoutErrors(['SHIPPING_METHOD_APPLICATION_FAILED']);
queryClient.invalidateQueries({
queryKey: ['draft-order', session.id],
});
},
});
} else if (session?.enableTaxCollection) {
updateTaxes.mutate(undefined);
Expand All @@ -239,7 +230,6 @@ export function ShippingMethodForm() {
form,
applyShippingMethod,
updateTaxes.mutate,
setCheckoutErrors,
session?.enableTaxCollection,
queryClient,
session?.id,
Expand Down