resync order shipping of shipping lines and lineItems fulfillment NONE#1379
Open
pbennett1-godaddy wants to merge 6 commits into
Open
resync order shipping of shipping lines and lineItems fulfillment NONE#1379pbennett1-godaddy wants to merge 6 commits into
pbennett1-godaddy wants to merge 6 commits into
Conversation
🦋 Changeset detectedLatest commit: 3322ea5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wcole1-godaddy
approved these changes
May 29, 2026
Contributor
wcole1-godaddy
left a comment
wcole1-godaddy
left a comment
There was a problem hiding this comment.
Approved. Latest revision addresses my previous concerns, and CI is green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a checkout edge case where a customer can return to cart after selecting a shipping method, replace or add line items, and then land back on checkout with stale shippingLines but new line items
still set to fulfillmentMode: "NONE".
Because checkout saw the existing shippingLines, it treated shipping as already selected and allowed checkout to proceed. However, confirmCheckoutSession later removes shipping lines/totals when no
line items have fulfillmentMode: "SHIP".
This change updates the shipping method application logic so that when checkout detects existing shipping lines but line items still need shipping fulfillment, it reapplies the selected shipping
method. Reapplying the shipping method causes checkout-api to recalculate shipping and update line items to fulfillmentMode: "SHIP".
Changeset
Test Plan
pnpm --filter @godaddy/react test -- shipping-method