Sort transports generated by testing plugin#253
Merged
Conversation
Member
|
This is great! Thanks for tightening up the generated scenario output and adding coverage for the scenario types. One small follow-up: |
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the scenario-based testing code generation for services by improving how supported transports are handled and by adding comprehensive scenario type definitions for different service configurations. The changes increase maintainability and extensibility of the test code, especially around transport handling and scenario structure.
Enhancements to transport handling:
maps.Keysandslices.Sortedfor clarity and correctness inbuildScenariosData. [1] [2]Expanded scenario type definitions for test code:
ScenarioTypesWithPayloadCode,ScenarioTypesWithResultCode,ScenarioTypesWithoutPayloadResultCode) that define the structure of scenarios, steps, expectations, and transport availability for each service configuration. These definitions are now included in the generated test code for services with payload, with result, and without payload/result. [1] [2] [3]scenarios_test.goto expect the new scenario type code snippets in the generated output, ensuring tests cover the new scenario structure.