fix: serialize remote Taskfile clone across processes (fixes #3011) - #3012
Open
fwh888 wants to merge 1 commit into
Open
fix: serialize remote Taskfile clone across processes (fixes #3011)#3012fwh888 wants to merge 1 commit into
fwh888 wants to merge 1 commit into
Conversation
…3011) The in-process sync.Mutex only protects goroutines within one Task process. When an IDE extension, shell completion and a terminal invoke Task at the same time, two processes can clone the same repo cache dir concurrently and corrupt it. - New lockRepoCache() takes an exclusive flock on a lock file outside the cache dir (which CleanGitCache removes) - getOrCloneRepo acquires it before the cache check / clone - Test: two acquisitions of the same key are mutually exclusive (second blocks until release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3011: concurrent Task processes cloning the same remote Git Taskfile now serialize via a cross-process
flock.lockRepoCachetakes an exclusive file lock (lock file lives inos.TempDir()/task-git-repos-locks, outside the cache dir thatCleanGitCacheremoves)getOrCloneRepoacquires it before the cache check and cloneTests
TestLockRepoCache_MutuallyExclusive: second lock blocks until first releasesgo test ./taskfile/passesFixes #3011