Skip to content

Custom split char - #49

Draft
greut wants to merge 4 commits into
go-cmd:mainfrom
greut:custom-split-char
Draft

greut wants to merge 4 commits into
go-cmd:mainfrom
greut:custom-split-char

Conversation

@greut

@greut greut commented May 24, 2020

Copy link
Copy Markdown
Contributor

An experiment to allow other split character, such as \0 for git ls-files -z output.

greut added 2 commits May 24, 2020 09:27
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
Signed-off-by: Yoan Blanc <yoan@dosimple.ch>
@coveralls

coveralls commented May 24, 2020 •

Copy link
Copy Markdown

Coverage Status

coverage: 98.677% (-0.8%) from 99.464% — greut:custom-split-char into go-cmd:main

@daniel-nichter

Copy link
Copy Markdown
Member

Given that you're merging changes 6 years later, I presume you're still using this pkg with a custom split char @greut ? Probably time I merge it, just one request: s/*byte/byte/ to avoid any nil pointer issues, and then DEFAULT_SPLIT_CHAR = '\n' along with the other stream-related default const. I haven't tried it but I think those changes will work and fit with current code conventions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants