Lazy evaluating parsed json in GlobusHttpResponse#1381
Merged
sirosen merged 4 commits intoglobus:mainfrom May 1, 2026
Merged
Conversation
AK2000
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
sirosen
reviewed
Apr 27, 2026
Member
sirosen
left a comment
sirosen
left a comment
There was a problem hiding this comment.
Thanks for this patch, it looks good! (And I was wrong about needing to make it conditional, so 👍 to not doing that. 😅 )
I think we need a regression unit test, but I'm happy for the SDK maintainers to take on that responsibility (unless you want to do it). I plan to add a test and ask for someone else to act as a co-reviewer.
Member
|
I added the requisite unit test and fixed that EDIT: oh, and I noticed that the changelog needed some fixing, so that's included too. |
The test confirms that a streaming response is not read on init but is read when attribute access forces it. Also, fix a minor stylistic issue regarding assert vs explicit branching.
ada-globus
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for issue #1380 that works with my event streaming client. Lazy evaluating parse json in globus responses to fix streaming. This does not affect any other error handling in the test suite but it also does not use @sirosen's suggestion that we only move to lazy parsing when streaming is enabled