fix: register Temporal workers for hyphenated provider identifiers (instagram-standalone)#1303
Open
Linus-tom wants to merge 1 commit intogitroomhq:mainfrom
Open
fix: register Temporal workers for hyphenated provider identifiers (instagram-standalone)#1303Linus-tom wants to merge 1 commit intogitroomhq:mainfrom
Linus-tom wants to merge 1 commit intogitroomhq:mainfrom
Conversation
Providers like 'instagram-standalone' were being excluded by the filter:
.filter((f) => f.identifier.indexOf('-') === -1)
This meant no Temporal worker was ever created for Instagram, causing
posts to remain in QUEUE state indefinitely.
The fix replaces the exclusion filter with deduplication by base provider
name (the part before the first hyphen). A Set tracks seen queue names
so only one worker is created per base provider (e.g. 'instagram' from
'instagram-standalone').
|
@Linus-tom is attempting to deploy a commit to the Listinai Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Providers with hyphenated identifiers (e.g.
instagram-standalone) are excluded by the worker filter intemporal.module.ts:This means no Temporal worker is ever created for Instagram, causing posts to remain stuck in
QUEUEstate indefinitely and never getting published.Fix
Replace the exclusion filter with deduplication by base provider name (the part before the first hyphen). A
Settracks seen queue names so only one worker is registered per base provider:This ensures
instagram-standalonegets a worker on theinstagramtask queue, while still preventing duplicate workers for providers that share the same base name.Impact
main,youtube,pinterestetc. continue working as before