Skip to content

chore: declare pnpm via devEngines.packageManager - #808

Merged
setchy merged 1 commit into
mainfrom
chore/devengines-package-manager
Oct 28, 2026
Merged

setchy merged 1 commit into
mainfrom
chore/devengines-package-manager

Conversation

@setchy

@setchy setchy commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

Moves the pnpm pin from the legacy top-level packageManager field into devEngines.packageManager:

  • before: "packageManager": "pnpm@12.14.0"
  • after: "devEngines": { ..., "packageManager": { "name": "pnpm", "version": "12.14.0", "onFail": "download" } }

Same exact version, so there is no change to the resolved manager. pnpm 12 records it under packageManagerDependencies and can self-provision; Corepack ≥0.36 and both pnpm/action-setup and pnpm/setup read the field.

Notes:

  • corepack use pnpm@… would re-add the top-level field, so use corepack install or edit devEngines instead.
  • Node 25+ no longer bundles Corepack, so the devEngines path is the forward-looking one.

Verification

  • package.json parses; no top-level packageManager remains
  • pnpm install --lockfile-only resolves the same pnpm version
  • Lockfile unchanged (except the specifier hash where noted)

@setchy
setchy requested a review from afonsojramos as a code owner October 28, 2026 12:29
@netlify

netlify Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for gitify ready!

Name Link
🔨 Latest commit b958216
🔍 Latest deploy log https://app.netlify.com/projects/gitify/deploys/6ae1eab95f2362185c5b6901
😎 Deploy Preview https://deploy-preview-808--gitify.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 85 (🔴 down 8 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@sonarqubecloud

Copy link
Copy Markdown

@setchy
setchy merged commit d46baf1 into main Oct 28, 2026
15 checks passed
@setchy
setchy deleted the chore/devengines-package-manager branch October 28, 2026 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant