Skip to content

Enforce CI typechecking for extracted Rig markdown samples - #275

Merged
pelikhan merged 2 commits into
mainfrom
copilot/ci-job-sample-parsing
Jul 29, 2026
Merged

Enforce CI typechecking for extracted Rig markdown samples#275
pelikhan merged 2 commits into
mainfrom
copilot/ci-job-sample-parsing

Conversation

Copilot AI commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

CI currently exercises samples, but it did not reliably gate on TypeScript validity of the code embedded in skills/rig/samples/*.md. This change makes CI explicitly parse each markdown sample, extract its rig block, and typecheck those extracted programs.

  • CI gate for markdown sample type safety

    • Added a dedicated CI step to run only the markdown-sample typecheck suite via:
      • npm run sample -- --testNamePattern="skill markdown samples typecheck"
  • Sample typecheck harness now compiles extracted code

    • Updated scripts/run-sample.test.ts to materialize extracted rig snippets as .ts files in a temp directory.
    • Generates a temporary tsconfig.json extending repo config and runs tsc --project ... so extracted snippets are actually compiled.
    • Disables noUnusedLocals and noUnusedParameters in this temp config to avoid false negatives from intentionally minimal sample snippets.
  • Sample compatibility cleanup

    • Updated skills/rig/samples/70-multi-file-subagent-summarizer.md to remove deprecated workflow({ output: ... }) usage so it conforms to current workflow typings.
# .github/workflows/ci.yml
- name: Typecheck extracted markdown rig samples
  run: npm run sample -- --testNamePattern="skill markdown samples typecheck"

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Ensure CI typechecks extracted rig markdown samples Enforce CI typechecking for extracted Rig markdown samples Jul 29, 2026
Copilot AI requested a review from pelikhan July 29, 2026 08:40
Comment thread scripts/run-sample.test.ts Outdated
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI requested a review from pelikhan July 29, 2026 08:48
@pelikhan
pelikhan marked this pull request as ready for review July 29, 2026 08:53
@pelikhan
pelikhan merged commit 40f3626 into main Jul 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants