Repository navigation
[self-care:server-go-logging] Extract adxtrace candidate classification with diagnostic logging - #20199
Merged
pelikhan merged 3 commits intoNov 4, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
Author
|
@copilot Fix failing checks |
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Contributor
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
pelikhan
deleted the
self-care/server-go-logging-adxtrace-capture-115b806acc84cb72
branch
November 4, 2026 17:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
server/internal/adxtrace/capture.goso per-run evidence classification lives in a testablecaptureCandidatefunction, and adds one debug summary log (cao:adxtrace) per capture pass. Behavior is unchanged.Action: Reviewer should confirm the extraction is behavior-preserving and that
go -C server vet ./... && go -C server test ./...passes.Change
CaptureEvidenceloop body moved intocaptureCandidate, which returns evidence, an exclusion reason, or an I/O error. Reason strings and placeholder evidence are identical to before.cacheLog.Printfafter a completed pass logs only counts: candidates, projected, excluded. Disabled by default. No identifiers, paths, errors, or content are logged, and it is outside the per-candidate loop.Tests
New
capture_test.gouses real temp directories and real projection (no mocks) to cover projected, identity-gap, directory-gap, unavailable, invalid-source and size-exclusion outcomes, plus out-of-scope repository skipping.Validation
gofmtclean;go -C server vet ./...andgo -C server test ./...pass.Control Plane
41829643232-3314githubnext/gh-cao