Repository navigation
[self-care:server-go-logging] Extract audit lifecycle classification and add scan logging - #20166
Merged
mnkiefer merged 2 commits intoNov 4, 2026
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mnkiefer
deleted the
self-care/server-go-logging-auditlifecycle-39f4606f9c2260aa
branch
November 4, 2026 12:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
server/internal/auditlifecycleso per-rebuild classification and overall status derivation are separate, directly testable units, and adds one debug log at scan completion.Action: Reviewer should confirm
Scanbehavior is unchanged and thatgo -C server test ./internal/auditlifecyclepasses.Changes
Scannow delegates toclassify(classification and counters) andoverallStatus(ok, attention or incomplete). The logic is moved verbatim and the public API is unchanged.cao:auditlifecyclenamespace, disabled by default, emitted after the scan completes. It records only already-computed scalars: status, scanned count, finding count, and tail-reached flag. It does not log rebuild IDs, attributes, or error text, and it does not affect control flow.TestClassifyAssignsClassificationAndCounters(complete, pending, missing-terminal, unknown for zero time, clock uncertainty, an incomplete tail, and a history gap) andTestOverallStatus.Validation
gofmtclean,go -C server vet ./...clean,go -C server test ./...all passing.Control Plane
41706006673-3265githubnext/gh-cao