Skip to content

feat: replace Unicode circle checkmarks with Primer octicon SVGs - #2300

Merged
pelikhan merged 1 commit into
mainfrom
copilot/update-checkmarks-to-primer-icons
Jul 28, 2026
Merged

feat: replace Unicode circle checkmarks with Primer octicon SVGs#2300
pelikhan merged 1 commit into
mainfrom
copilot/update-checkmarks-to-primer-icons

Conversation

Copilot AI commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Task-list checkmarks were rendered as Unicode text characters (/), which don't scale cleanly or align with the Primer design system.

Changes

  • scripts/lib/marked-setup.jslistitem renderer emits inline Primer octicon SVGs (check-circle-fill / circle, 16 px) instead of /
  • scripts/static/docs-checkboxes.jsapplyItemState switches from marker.textContent to marker.innerHTML using two module-level SVG string constants
  • scripts/lib/docs.css — strips text-character artifacts (border, border-radius, font-size, font-weight, line-height) from .task-list-item-marker; layout is now inline-flex; colour tokens (--fgColor-success, --fgColor-attention) drive icon colour via fill="currentColor"
  • scripts/build-docs.test.js — assertion updated to match SVG marker output
<!-- before -->
<span class="task-list-item-marker is-pending" aria-hidden="true"></span>

<!-- after -->
<span class="task-list-item-marker is-pending" aria-hidden="true">
  <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 16 16" width="16" height="16" fill="currentColor">
    <path d="M0 8a8 8 0 1 1 16 0A8 8 0 0 1 0 8Zm8-6.5a6.5 6.5 0 1 0 0 13 …Z"></path>
  </svg>
</span>

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title feat: use Primer octicon SVGs for task-list checkmarks feat: replace Unicode circle checkmarks with Primer octicon SVGs Jul 28, 2026
Copilot AI requested a review from pelikhan July 28, 2026 16:22
@pelikhan
pelikhan marked this pull request as ready for review July 28, 2026 20:29
@pelikhan
pelikhan merged commit 0fae941 into main Jul 28, 2026
@pelikhan
pelikhan deleted the copilot/update-checkmarks-to-primer-icons branch July 28, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants