-
Notifications
You must be signed in to change notification settings - Fork 10.1k
fix: derive plan path from feature.json in update-agent-context #3069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
amirreza225
wants to merge
15
commits into
github:main
Choose a base branch
from
amirreza225:fix/3067-feature-json-plan-path
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+392
−24
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cf0a80d
fix: derive plan path from feature.json in update-agent-context
amirreza225 b290c03
fix: address Copilot review feedback on update-agent-context
amirreza225 d710b62
Potential fix for pull request finding
amirreza225 b2aee03
test: replace time.sleep with os.utime and strengthen PS normalizatio…
amirreza225 9940cdb
Apply suggestions from code review
amirreza225 be127bd
Potential fix for pull request finding
amirreza225 80b96c8
fix: normalize trailing slash and guard non-string feature_directory …
amirreza225 11530c2
Fix: use .resolve().as_posix().
amirreza225 870e7ec
fix: use context manager for feature.json open() in bash heredoc
amirreza225 93dda10
test: add PS coverage for absolute feature_directory outside project …
amirreza225 dc1c0fa
fix: guard null feature_directory, re-check empty after trailing-slas…
amirreza225 1808ce7
test: add stale plan to absolute-path tests so feature.json preferenc…
amirreza225 b24279b
test: convert absolute paths to MSYS2 style for Git-for-Windows bash …
amirreza225 855550e
fix: revert PS test to native path, fix bash outside-root assertion f…
amirreza225 8e3d78a
fix: use _to_bash_path in not-in assertion for Git bash Windows compat
amirreza225 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.