Conversation
The default year option compared UTC years, so a date that falls in a different calendar year in the element's time zone (or the browser's) lost its year, or got one it did not need, near New Year.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
When the
yearattribute is not set, theyeargetter decides whether to show the year withnew Date().getUTCFullYear() !== this.date?.getUTCFullYear(). That compares UTC years, but the date is rendered in the element'stime-zone(or the browser's). Near New Year the two disagree, so a date from last year can lose its year, or a date from this year can get one.Example: with
time-zone="America/New_York"and the current date in June 2023,datetime="2023-01-01T02:00:00.000Z"renders asSat, Dec 31instead ofSat, Dec 31, 2022.Fix
Reuse the existing
#isCurrentYear(date, locale, timeZone)helper (already used by the absolute time format), so the year is compared in the same time zone the date is displayed in. When there is no date the getter still returns'numeric', as before.Testing
Added a test in the
[timeZone]suite for the example above.expected 'Sat, Dec 31' to equal 'Sat, Dec 31, 2022'(634 passed, 1 failed)npm run lintpasses