fix(github): sanitize PR review and discussion bodies on read paths - #3039
Open
SashaMIT wants to merge 1 commit into
Open
fix(github): sanitize PR review and discussion bodies on read paths#3039SashaMIT wants to merge 1 commit into
SashaMIT wants to merge 1 commit into
Conversation
Issue/PR title and body reads already run through sanitize.Sanitize. PR review bodies, review-thread comments, and Discussion title/body/comments still returned raw attacker-controlled text into the model context. Apply the same sanitize control on those sibling read paths. Clean content is unchanged; lockdown filtering is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Issue and PR title/body reads already run through
sanitize.Sanitize(invisible Unicode tags, BiDi overrides, HTML, code-fence metadata) before content reaches the model. Several sibling user-authored read paths still returned raw text:convertToMinimalPullRequestReview) — review bodies verbatim.convertToMinimalReviewComment) — comment bodies verbatim.get_discussion/list_discussions/get_discussion_comments) — titles, bodies, and comment/reply bodies verbatim.A hostile review or Discussion post could therefore carry hidden prompt-injection payloads into the context window, bypassing the baseline control its sibling issue/PR paths apply. Related prior: #3035 (issue comments + sub-issues).
Fix
Apply the same
sanitize.Sanitizeon those converters and Discussion response builders. No behavior change for clean content; lockdown-mode filtering is untouched and orthogonal.Testing
go test ./pkg/github/ ./pkg/sanitize/pass.Made with Cursor