Skip to content

analyze table before cutover - #1419

Open
wangzihuacool wants to merge 2 commits into
github:masterfrom
wangzihuacool:master
Open

analyze table before cutover#1419
wangzihuacool wants to merge 2 commits into
github:masterfrom
wangzihuacool:master

Conversation

@wangzihuacool

Copy link
Copy Markdown
Contributor

Related issue: #1418

Description:
analyze ghost table before cutover to avoid table statistics not timely updated.

@meiji163

Copy link
Copy Markdown
Contributor

LGTM

@shaohk

shaohk commented May 30, 2024

Copy link
Copy Markdown
Contributor

When the modified table is a partition table, the execution time of the ANALYZE command will increase as the number of partitions increases. When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

@meiji163

Copy link
Copy Markdown
Contributor

When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

Maybe make this feature a optional flag then? What do you think @timvaillancourt ?

@timvaillancourt timvaillancourt left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timvaillancourt

Copy link
Copy Markdown
Collaborator

When the modified table is a partition table, the execution time of the ANALYZE command will increase as the number of partitions increases. When the ANALYZE statement is synchronized to the replica, it may cause replication lag.

@meiji163 considering this (I didn't think of it) I suggest this is an optional flag for now and we can have opt-in users report on performance

@wangzihuacool can you add an optional flag and doc/command-line-flags.md update for this one?

@Zorgon66

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants