Add a TUI when invoked without arguments - #18
Open
colinstark wants to merge 32 commits into
Open
colinstark wants to merge 32 commits into
colinstark wants to merge 32 commits into
Conversation
Use the API-required system-pat reference for source-driven migration creation in both CLI and TUI workflows, with request-level regression coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Repository records now retain API metadata through the workflow catalog for TUI use. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Improve responsive repository details, richer card and button decoration, functional shortcuts, and independent always-valid action focus. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep existing migration details visible until refreshed values arrive, and preserve them when a refresh fails. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hide refresh and messages until source migrations start, and support terminal-style Alt+Delete word removal in editable form fields. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep migration details and lists current without loading flashes, improve migration headers and creation results, and refine cancellation labels and list overflow layout. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Hide migration-only progress states from cutover output while retaining readiness, blockers, repository details, and cutover lifecycle statuses. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Give every form a contextual primary button and a Cancel button, matching the configuration form interaction pattern. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep destination operations accessible through source migration details and remove redundant advanced navigation and branding from the TUI. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Target progress grouping mishandles prefixed protobuf resource types, causing incorrect labels and totals.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Polishes interactive migration workflows and enriches migration metadata and progress rendering.
Changes:
- Refines TUI navigation, forms, overlays, actions, and native cursor handling.
- Adds repository metadata and destination progress summaries.
- Normalizes configuration/API behavior and expands regression coverage.
| File | Description |
|---|---|
| README.md | Updates TUI usage guidance. |
| internal/workflow/service.go | Refines configuration, repositories, and PAT handling. |
| internal/workflow/service_test.go | Tests workflow service changes. |
| internal/tui/view.go | Overhauls TUI rendering and progress views. |
| internal/tui/model.go | Refactors navigation, forms, actions, and state. |
| internal/tui/model_test.go | Expands TUI workflow coverage. |
| internal/tui/keys.go | Updates search-key help. |
| internal/tui/cursor.go | Adds native terminal cursor support. |
| internal/tui/cursor_test.go | Tests cursor adaptation. |
| internal/tui/components.go | Adds badges and improved buttons. |
| internal/theme/theme.go | Extends semantic styling. |
| internal/theme/theme_test.go | Tests theme additions. |
| internal/render/migration.go | Refines status and progress rendering. |
| internal/render/migration_test.go | Tests migration presentation. |
| internal/endpoints/endpoints.go | Normalizes bare target hostnames. |
| internal/endpoints/endpoints_test.go | Tests hostname normalization. |
| internal/elmapi/target_migrations.go | Models target summaries and encoded counts. |
| internal/elmapi/target_migrations_test.go | Tests target response decoding. |
| internal/elmapi/migrations.go | Defines the system PAT reference. |
| internal/elmapi/catalog.go | Preserves repository metadata. |
| internal/elmapi/catalog_test.go | Tests repository metadata decoding. |
| internal/cmd/tui.go | Installs native cursor output. |
| internal/cmd/migration/watch/watch_test.go | Tests cancelled terminology. |
| internal/cmd/migration/watch/view.go | Displays terminated migrations as cancelled. |
| internal/cmd/migration/watch/phases.go | Updates termination labels. |
| internal/cmd/migration/migration.go | Uses the system PAT reference. |
| internal/cmd/migration/migration_test.go | Updates command behavior assertions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This PR adds a full-screen terminal UI for Enterprise Live Migrations. Running
gh elmwith no arguments in an interactive terminal now opens a guided interface for configuring endpoints, creating and operating migrations, inspecting destination-side state, managing reports and resources, and reclaiming mannequins.The existing command-line commands and machine-readable output remain available for automation. When input or output is not an interactive terminal, bare
gh elmcontinues to show command help.What’s included
Guided configuration
Migration discovery and creation
org/repoentry when API discovery is unavailable or undesirable.Source migration management
Destination migration management
Resources and reports
Mannequin management
Terminal experience
j/knavigation, Enter to select, Escape to go back,/to search,Ctrl+Vto change list density, Page Up/Page Down for long views,?for contextual help, andqto quit.Shared workflow layer
Documentation and tests
Testing
go test ./...