Post E2E results to pull requests - #11
Merged
Merged
Conversation
gh-elm E2E resultsOverall result: ✅ Passed
Control-plane scenario
Lifecycle scenario
|
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 27, 2026 23:18
c45998c to
b01ed4a
Compare
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 27, 2026 23:57
b01ed4a to
b2e0060
Compare
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 28, 2026 00:05
b2e0060 to
edbd75c
Compare
isaevt
marked this pull request as ready for review
August 28, 2026 00:07
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Requiring the new reporting script prevents otherwise valid older candidates from running E2E.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (1)
| Severity | Finding |
|---|---|
 |
.github/workflows/e2e.yml — Making the PR-summary script part of required_harness_files prevents E2E from running for… |
What changed in this PR
Adds sticky E2E result summaries to matching pull requests.
Changes:
- Finds a pull request matching the candidate SHA.
- Renders and updates compact scenario results.
- Removes the skipped pause/resume lifecycle entry.
| File | Description |
|---|---|
.github/workflows/e2e.yml |
Discovers PRs and posts results. |
script/e2e/post-pr-summary.sh |
Renders and manages sticky comments. |
script/e2e/scenarios/lifecycle.sh |
Removes the obsolete skipped result. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 28, 2026 00:18
edbd75c to
fdb84dd
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Candidate code receives PR-write access, and stale runs can overwrite the summary after the PR head advances.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
 |
.github/workflows/e2e.yml — The workflow-level write permission is inherited by the e2e job, where the checked-out candidate… |
|
.github/workflows/e2e.yml — The head SHA is checked only in the earlier resolve job. Because this job can wait for… |
Issues resolved since last review (1)
| Severity | Finding |
|---|---|
|
.github/workflows/e2e.yml — Making the PR-summary script part of required_harness_files prevents E2E from running for… View resolved comment |
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 28, 2026 00:34
fdb84dd to
67d052e
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Candidate-controlled evidence can expose secrets, and missing evidence can produce a misleading passed report.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review tier: Balanced
Findings: 1
New issues introduced by this change (2)
| Severity | Finding |
|---|---|
|
script/e2e/post-pr-summary.sh — The artifact is produced by candidate-controlled code that receives SOURCE_TOKEN and… |
|
.github/workflows/e2e.yml — If artifact download fails after a successful E2E job, this branch continues and the reporter posts… |
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
.github/workflows/e2e.yml — The head SHA is checked only in the earlier resolve job. Because this job can wait for… View resolved comment |
|
.github/workflows/e2e.yml — The workflow-level write permission is inherited by the e2e job, where the checked-out candidate… View resolved comment |
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 28, 2026 01:13
67d052e to
cc10694
Compare
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
The security-sensitive workflow depends on externally configured environment branch protections that require human verification.
Review tier: Balanced
Findings: None
Issues resolved since last review (2)
| Severity | Finding |
|---|---|
|
.github/workflows/e2e.yml — If artifact download fails after a successful E2E job, this branch continues and the reporter posts… View resolved comment |
|
script/e2e/post-pr-summary.sh — The artifact is produced by candidate-controlled code that receives SOURCE_TOKEN and… View resolved comment |
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 28, 2026 01:20
cc10694 to
575efca
Compare
dpmex4527
approved these changes
Aug 31, 2026
Comment on lines
+11
to
+13
| # Permissions are granted per job. Candidate-controlled code must not receive a | ||
| # token capable of modifying pull requests. | ||
| permissions: {} |
stack merge was automatically disabled
August 31, 2026 19:56
Pull Request is not mergeable
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 31, 2026 20:11
575efca to
09d4b3b
Compare
Discover the same-repository pull request associated with an E2E candidate and post a compact, updatable results summary. Keep candidate execution read-only and perform pull request updates in a separate trusted reporting job. Recheck the pull request head before posting, validate successful-run evidence, and map untrusted artifact values to fixed labels before including them in the comment. Continue running E2E normally when no matching pull request exists.
isaevt
force-pushed
the
isaevt/e2e-pr-summary
branch
from
August 31, 2026 20:19
09d4b3b to
ca1028c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Post a compact E2E results summary to the pull request associated with the tested candidate.
Candidate execution and pull request reporting use separate jobs so candidate-controlled code cannot modify pull requests through
GITHUB_TOKEN.What changed
pull-requests: writeonly to the reporting job.