Skip to content

Add isolated OIDC admission and runtime credit allowances - #70429

Merged
pelikhan merged 22 commits into
mainfrom
pelikhan-stunning-doodle
Oct 20, 2026
Merged

pelikhan merged 22 commits into
mainfrom
pelikhan-stunning-doodle

Conversation

@pelikhan

@pelikhan pelikhan commented Oct 20, 2026 •

Copy link
Copy Markdown
Collaborator

Why

Implement the OIDC admission contract introduced in #70286 so participating workflows can consult a centralized authority before agent execution. Validated admission supersedes daily-AIC validation and supplies component-specific runtime credit limits.

Implementation

  • Emit a dedicated compiler-owned admission job, gated at job level by vars.GH_AW_DEFAULT_ADMISSION_URL. An absent endpoint skips its runner, setup and OIDC acquisition. Daily-AIC validation and its credentials remain in activation; daily-limit variables do not enable admission.
  • Grant admission only contents: read and id-token: write. Admission does not run workflow hooks or mint workflow/telemetry App credentials. Reject all jobs.admission frontmatter customization, including setup-steps, pre-steps, steps, permissions and environment overrides. Activation receives no admission-only OIDC grant; independent workflow OIDC requirements remain supported.
  • Make activation depend on admission and explicitly accept success or skip, reject failure/cancellation, and preserve its original prerequisite and eligibility conditions. Protect downstream jobs against GitHub Actions skipped-ancestor propagation without weakening required dependency results or overriding explicit status-function conditions.
  • Authenticate using native Actions OIDC only. Preserve the ten-string-field POST contract, caller-owned W3C trace context, strict response validation, bounded retries and shared 60-second monotonic deadline. No service response trace identifiers are accepted.
  • Relay validated primary, threat-detection and evals allowances through activation outputs into existing runtime enforcement. Supplied allowances replace the corresponding local caps; omitted optional allowances preserve independent component policy. Missing/invalid required admitted limits fail closed. Remove handoff environment variables before agent execution.
  • Record status and validated numeric allowances in guardrail.admission unified-session events with admission provenance, and propagate the component values to detection/evals. Human-readable lifecycle logs and collapsed step-summary details withhold identities, credentials, endpoint configuration, allowance amounts, spend and service diagnostics.
  • Update the service specification, ADR, release note, regression coverage and TLA+ model, including admission-job isolation and activation dependency invariants.

Validation

  • All 345 repository workflows regenerated successfully. Build, formatting, changed-file publication gate and focused compiler regressions passed after integrating concurrent branch/main changes.
  • JavaScript type checking and admission/unified-session suites passed: 292 tests.
  • All four secure TLA+ profiles, 29 negative controls and 18 witnesses verified; checker harness tests passed.
  • Regression coverage includes rejection of each frontmatter hook form, endpoint-only gating, daily-AIC placement/fallback, OIDC permission isolation, skipped-admission dependency conditions, independent runtime allowances, and unified-session propagation.
  • No live workflow runs were triggered. Earlier macOS/platform/toolcache failures in broad package runs are not presented as full-suite success.

Operational scope

Admission is cooperative rather than an unbypassable organization spending cap. Authoritative enforcement still requires protected backend authorization/accounting. The independently implemented server contract is unchanged; its initial deployment profile supports GitHub.com, string audiences and non-reusable workflows, failing closed for unsupported reusable identities. No server or Actions rollout configuration is changed here.

Most of the diff is regenerated workflow lock files. Reusable caller permission envelopes must permit the callee's admission OIDC capability.


Changeset

  • Type: patch
  • Description: Add isolated OIDC admission with validated component-specific runtime credit allowances and redacted unified-session reporting.

Generated by 📋 Changeset Generator for #70429 · codex · gpt56 · 38 AIC · ⌖ 25.6 AIC · ⊞ 15.7K · ◷

pelikhan and others added 2 commits October 19, 2026 18:56
Condition admission and OIDC acquisition on managed endpoint configuration. Valid approval supersedes daily validation; disabled admission and ignored outages retain daily fallback. Keep required primary and optional component allowances inside activation, use caller-owned traceparent correlation, and leave agent jobs unchanged. Align the specification, regression coverage, and TLA+ model.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Initialize the actions/github-script globals before loading the admission client. Include the compiler-owned frontmatter/body fingerprint in requests as a stable workflow_hash cache hint, with strict validation and documented authorization and cache-isolation requirements. Regenerate all workflow locks without changing downstream jobs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
pelikhan and others added 3 commits October 19, 2026 22:17
Reject the unsupported admission-gate frontmatter switch, retain admission in every activation job, and grant OIDC to hand-authored reusable callers. Assemble admission module paths with node:path before initializing github-script globals and loading the client.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve admission deadlines, cancellation, retry classification, and sanitized diagnostics while delegating retry policy to withRetry.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Add optional operation timeouts, monotonic deadlines, and cancellable waits to the shared retry helper. Replace admission's bespoke timer and abort handling while preserving its retry budget and sanitized errors.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 20, 2026 06:08
Copilot AI max review requested due to automatic review settings October 20, 2026 06:08
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · 14.1 AIC · ⌖ 15.1 AIC · ◇ 6.6 AIC · ⊞ 12.6K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · 14.4 AIC · ⌖ 5.37 AIC · ⊞ 14.7K · ◷

Generated by Ponytail Reviewer for #70429

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Commit pushed: 82b3ac3

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes

Two blocking issues found in the admission runtime:

  • The control-character regex rejects ordinary uppercase characters, so valid configured endpoints and identities fail admission.
  • id-token: write is granted unconditionally to every activation job, including workflows with admission disabled; the step condition cannot sandbox OIDC minting.

Inline comments explain the impact and surgical fixes. Static review only; no tests or repository code were executed.

🔎 Code quality review by PR Code Quality Reviewer · copilot · gpt50 · 6.46 AIC · ⌖ 0.553 AIC · ⊞ 1.6K
Comment /review to run again

Comment thread actions/setup/js/admission_protocol.cjs
Comment thread pkg/workflow/compiler_activation_permissions.go Outdated
@github-actions

Copy link
Copy Markdown
Contributor

🏗️ Design Decision Gate — ADR Required

This PR adds about 327 new lines of core business logic (more than the 100-line threshold) but does not link an Architecture Decision Record (ADR).

📄 Draft ADR committed: docs/adr/70429-activation-only-oidc-admission-service-runtime.md. Please review and complete it before merging.

The draft records these decisions:

  • An OIDC-only admission step runs in the activation job only.
  • A validated approval replaces the daily-AIC guardrail. Disabled admission and ignored outages fall back to the daily-AIC check.
  • Every activation job gets id-token: write, including reusable caller envelopes.
  • The shared withRetry helper gains per-attempt timeouts and an absolute deadline.

🔒 This PR cannot merge until an ADR is linked in the PR body.

📋 What to do next
  1. Review the draft ADR committed to your branch. It was generated from the PR description and the file patches, because the full diff was too large to fetch.
  2. Complete the missing sections. Check the alternatives against what you actually considered. In particular, check whether id-token: write should be granted unconditionally rather than at compile time, and whether admission should replace the daily-AIC check or run alongside it.
  3. Commit the finalized ADR to docs/adr/ on your branch.
  4. Reference the ADR in this PR body by adding a line such as:

    ADR: ADR-70429: Activation-Only OIDC Admission Service Runtime

Once an ADR is linked in the PR body, this gate will re-run and verify that the implementation matches the decision.

❓ Why ADRs Matter

"AI made me procrastinate on key design decisions. Because refactoring was cheap, I could always say 'I'll deal with this later.' Deferring decisions corroded my ability to think clearly."

ADRs create a searchable, permanent record of why the codebase looks the way it does. Future contributors (and your future self) will thank you.

📋 Michael Nygard ADR Format Reference

An ADR must contain these four sections to be considered complete:

  • Context: What is the problem? What forces are at play?
  • Decision: What did you decide? Why?
  • Alternatives Considered: What else could have been done?
  • Consequences: What are the trade-offs (positive and negative)?

All ADRs are stored in docs/adr/ as Markdown files numbered by PR number.

🏗️ ADR gate enforced by Design Decision Gate 🏗️ · pi · opus55 · 35.4 AIC · ⌖ 40.8 AIC · ⊞ 1.9K · ◷
Comment /review to run again

pelikhan and others added 3 commits October 19, 2026 23:17
Apply validated admission limits to agent, threat-detection, and evals runtime credit budgets, preserving existing policy for absent optional allowances and skipped or ignored admission. Add privacy-preserving lifecycle logs and collapsed step summaries, extend runtime JSON regression coverage, update the specification and TLA+ invariants, and regenerate workflows.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Preserve the concurrently added draft ADR and update its decision and consequences for the requested runtime budgets and redacted reporting.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan changed the title Add activation-only OIDC admission service runtime Add OIDC activation admission and runtime credit allowances Oct 20, 2026
@pelikhan
pelikhan marked this pull request as draft October 20, 2026 06:19

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skills-Based Review 🧠

Applied /tdd, /codebase-design, and /grill-with-docs on the admission-runtime high-impact files (compiler_admission.go, check_admission.cjs, admission_protocol.cjs, compiler_activation_permissions.go, call_workflow_permissions.go, error_recovery.cjs, and the updated spec). Overall this is a well-scoped, defense-in-depth implementation with strong test coverage (128 JS tests, dedicated Go compiler tests, and a TLA+ model with 27 negative controls). Approving with a few minor, non-blocking suggestions.

📋 Key Themes & Highlights

Key Themes

  • Strict protocol parsing: admission_protocol.cjs uses a hand-rolled regex grammar instead of trusting JSON.parse output directly, correctly handling duplicate-key and escaped-key attacks that a naive parse would miss — good defensive design for an untrusted external response.
  • Deadline/signal plumbing: error_recovery.cjs's new runWithinRetryBudget plus AbortSignal wiring through withRetry is a clean, backward-compatible extension (existing non-timeout callers are unaffected since operation() and sleep() still work without a signal).
  • Permission minimality trade-off documented: the PR body explicitly and correctly caveats that id-token: write on activation is not a sandbox boundary — good, since that is exactly the kind of assumption a reviewer would otherwise flag as a gap.
  • Two inline comments note minor coverage/documentation gaps: IPv6-without-brackets URL validation test, and the non-overridable id-token: write behavior in extractPermissionsFromMDFile deserving an explicit code comment since it diverges from the otherwise-declarative frontmatter permissions: convention elsewhere in the compiler.
  • One inline suggestion on runWithinRetryBudget's already-expired-deadline path is largely already covered by an equivalent withRetry-level test ("should not invoke operations after an expired deadline or zero timeout"), so treat it as a nice-to-have, not a gap.

Positive Highlights

  • ✅ Spec, TLA+ model, and implementation were updated together and stay internally consistent (verified hash pattern, trace fields, and optional-allowance semantics all match across .tla, .md, and .cjs/.go).
  • ✅ TestAdmissionRepositoryReusableCallerPermissions and TestAdmissionReusableCallerPermissionsWithStaleWorkerLock proactively guard the cross-cutting 344-lock-file regeneration against silent permission regressions.
  • ✅ Bounded body reads (readBoundedBody), strict content-type checks, and redirect: "manual" on both OIDC and admission fetches are solid baseline hardening against response-smuggling/SSRF-adjacent issues.

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer · copilot · sonnet50 · 111.1 AIC · ⌖ 15.3 AIC · ⊞ 10.1K
Comment /matt to run again

Comment thread pkg/cli/env_command.go
Comment thread pkg/workflow/call_workflow_permissions.go
Comment thread actions/setup/js/error_recovery.cjs

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Admission output and permission regressions, stale WASM fixtures, and missing caller-migration guidance block approval.

No open issues 🎉

What changed in this PR

Adds activation-only OIDC admission, intended to replace daily-AIC validation after approval without changing downstream execution or runtime budgets.

Changes:

  • Generates endpoint-gated admission checks with workflow hashes.
  • Expands activation and reusable-caller OIDC permissions.
  • Updates generated workflows, tracing, tests, documentation, and formal checks.

Unresolved issues include overwritten admission output, Markdown-worker write-all permission downgrades, stale WASM golden fixtures, and missing breaking-change migration guidance. Optional findings concern sequential OTLP export delays, duplicated action-path handling, and undocumented constants.

File Description
specs/​workflow-security/​check.py Updates admission controls and reachability witnesses.
specs/​workflow-security/​ActivationAdmission.cfg Selects revised admission invariants.
pkg/​workflow/​compilerenv/​manager.go Defines managed admission variables.
pkg/​workflow/​compiler_admission.go Generates the conditional admission step.
pkg/​workflow/​compiler_activation_permissions.go Grants activation OIDC access unconditionally.
pkg/​workflow/​compiler_activation_job.go Inserts admission before validation.
pkg/​workflow/​call_workflow_permissions.go Extends reusable-caller permission inference.
pkg/​workflow/​call_workflow_permissions_test.go Updates permission-import expectations.
pkg/​workflow/​agy_engine_test.go Updates scoped OIDC permission assertions.
pkg/​cli/​env_admission_test.go Tests admission defaults and validation.
docs/​src/​content/​docs/​reference/​enterprise-configuration.md Documents centralized admission deployment.
docs/​src/​content/​docs/​reference/​cost-management.md Explains admission precedence and daily-AIC fallback.
docs/​src/​content/​docs/​reference/​compiler-enterprise-environment-controls.md Documents managed variables and permission boundaries.
actions/​setup/​js/​send_otlp_span.test.cjs Tests rejection of zero trace identifiers.
actions/​setup/​js/​send_otlp_span.cjs Adds validated W3C traceparent construction.
actions/​setup/​js/​error_codes.cjs Defines the admission error category.
.github/​workflows/​windows.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​windows-grower.md Grants reusable-caller OIDC access.
.github/​workflows/​unbloat-docs.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​tidy.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​test-quality-sentinel.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​squad.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​squad-plan.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-water.yml Grants reusable-caller OIDC access.
.github/​workflows/​smoke-trigger.yml Grants reusable-caller OIDC access.
.github/​workflows/​smoke-test-tools.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-temporary-id.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-service-ports.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-project.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-pi.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-pi-routed.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-opencode.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-multi-pr.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-multi-caller.yml Grants reusable-caller OIDC access.
.github/​workflows/​smoke-kiro.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-goose.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-gemini.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-drive.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-cursor.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-crush.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-copilot.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-copilot-small.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-copilot-sdk.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-copilot-auto.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-copilot-arm.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-codex.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-claude.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-checkout-pr-dispatch.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-aider.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-agy.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-agent-public-none.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-agent-public-approved.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​smoke-agent-all-none.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​skillet.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​security-review.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​scout.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​refiner.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​q.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​purelock.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​pr-sous-chef.lock.yml Adds activation admission and OIDC access.
.github/​workflows/​pr-nitpick-reviewer.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​pr-code-quality-reviewer.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​ponytail-reviewer.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​plan.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​pdf-summary.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​mergefest.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​grumpy-reviewer.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​design-decision-gate.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​dependabot-burner.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​deep-report.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​daily-max-ai-credits-test.lock.yml Adds activation admission and OIDC access.
.github/​workflows/​daily-issues-report.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​daily-firewall-report.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​daily-doc-updater.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​daily-doc-healer.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​daily-community-attribution.lock.yml Gates wiki-ledger preparation and daily validation.
.github/​workflows/​daily-code-metrics.lock.yml Gates repository-ledger preparation and daily validation.
.github/​workflows/​daily-cli-performance.lock.yml Gates repository-ledger preparation and daily validation.
.github/​workflows/​credentials-check.yml Grants reusable-caller OIDC access.
.github/​workflows/​craft.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​code-simplifier.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​cloclo.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​ci-coach.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​changeset.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​avenger.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​artifacts-summary.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​archie.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​approach-validator.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​ai-moderator.lock.yml Adds admission and daily-AIC gating.
.github/​workflows/​ace-editor.lock.yml Adds admission after strict-policy enforcement.
.changeset/​admission-service-runtime.md Announces admission runtime behavior and boundaries.

Review effort: Max

@pelikhan
pelikhan marked this pull request as ready for review October 20, 2026 12:32
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · 14 AIC · ⌖ 16 AIC · ◇ 6.61 AIC · ⊞ 12.6K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · 6.65 AIC · ⌖ 5.31 AIC · ⊞ 14.7K · ◷

Generated by Ponytail Reviewer for #70429

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · 11.2 AIC · ⌖ 31.9 AIC · ◇ 15.8 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan changed the title Add OIDC activation admission and runtime credit allowances Add isolated OIDC admission and runtime credit allowances Oct 20, 2026
Regenerate workflow locks and verify the needs-consistency linter reports no findings.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan pelikhan added the smoke label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Smoke OTEL completed successfully!

Generated by Smoke OTEL

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

🎬 THE END — Smoke Claude MISSION: ACCOMPLISHED! The hero saves the day! ✨

💥 [THE END] — Illustrated by Smoke Claude

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✨ The prophecy is fulfilled... Smoke Codex has completed its mystical journey. The stars align. 🌟

🔮 The oracle has spoken through Smoke Codex

@github-actions

Copy link
Copy Markdown
Contributor

✨ Gemini awakens... Smoke Gemini begins its journey on this pull request...

@github-actions

Copy link
Copy Markdown
Contributor

🥧 Pi initializing... Smoke Pi begins on this pull request...

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ Smoke Copilot Auto completed successfully!

Generated by Smoke Copilot Auto for #70429

@github-actions github-actions Bot removed the smoke label Oct 20, 2026
@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

✅ All tools validated successfully! Agent Container Smoke Test confirms agent container is ready.

🔧 Tool validation by Agent Container Smoke Test

@github-actions

Copy link
Copy Markdown
Contributor

Gate asks for a token,
Admission grants credit's share—
Agents run in trust.

Inspired by PR #70429's OIDC admission job and runtime credit allowances.

Generated by 🌸 Smoke Copilot Auto for #70429 · copilot · auto · 9.1 AIC · ⌖ 3.76 AIC · ⊞ 6.4K · ◷
Add label smoke to run again

@github-actions

Copy link
Copy Markdown
Contributor

Smoke Test: MAI-Code-1.1-Flash

  • Repo activity was focused on docs, MCP/tooling, and workflow fixes.
  • Overall status: PASS
  • Bash command check: ✅

Generated by ⚡ Smoke Copilot MAI · copilot · mai11 · 0.753 AIC · ⌖ 0.249 AIC · ⊞ 18K · ◷
Comment /smoke-copilot-mai to run again
Add label smoke to run again

@github-actions

Copy link
Copy Markdown
Contributor

Comment Memory

Peek at saved memory (smoke-codex)
Quiet branches sway
Small checks cross the morning light
Green leaves greet the dawn

Note

This comment is managed by comment memory.

Expand the saved memory block to view or edit the persistent context for this thread.
Edit only the text inside the backtick fences; workflow metadata and the footer are regenerated automatically.

Learn more about comment memory

🔮 The oracle has spoken through Smoke Codex · codex · 10.5 AIC · ⌖ 0.626 AIC · ⊞ 21K · ◷
Comment /smoke-codex to run again

@github-actions

Copy link
Copy Markdown
Contributor

Commit pushed: 50b891d

Generated by Changeset Generator · codex · gpt56 · 38 AIC · ⌖ 25.6 AIC · ⊞ 15.7K

@github-actions

Copy link
Copy Markdown
Contributor

Agent Container Tool Check

Tool Status Version
bash ✅ GNU bash, version 5.2.21
sh ✅ available
git ✅ git version 2.55.0
jq ✅ jq-1.7
yq ✅ yq v4.54.1
curl ✅ curl 8.5.0
gh ✅ gh version 2.102.0
node ✅ v24.21.0
python3 ✅ Python 3.11.17
go ✅ go version go1.24.13
java ✅ openjdk 21.0.12.1
dotnet ✅ 10.0.401

Result: 12/12 tools available ✅

Playwright title validation

  • Expected title from file: playwright-o9xoRsSFZWbyPy5T8D8ya-MhQwsPe9Q9
  • Actual title: unavailable; the Playwright browser could not launch in this container
  • Error: /opt/google/chrome/chrome: /lib/x86_64-linux-gnu/libm.so.6: version GLIBC_2.43' not found (required by /run/awf-lib/browser-libs/usr/lib/x86_64-linux-gnu/libasound.so.2)`
  • Result: FAIL — exact title equality could not be verified because the browser runtime is incompatible with the container

🔧 Tool validation by Agent Container Smoke Test · pi · mai11 · 1.77 AIC · ⌖ 0.395 AIC · ⊞ 7.7K · ◷
Comment /smoke-test-tools to run again

@pelikhan
pelikhan merged commit be70cb4 into main Oct 20, 2026
2 checks passed
@pelikhan
pelikhan deleted the pelikhan-stunning-doodle branch October 20, 2026 16:39
@github-actions

Copy link
Copy Markdown
Contributor

Smoke Copilot: FAIL (partial) — PR "Add isolated OIDC admission and runtime credit allowances" by @pelikhan (no assignees). ✅ gh query, discussion query; ⚠️ build unverified; ❌ remaining tests not run (permission denied).

📰 BREAKING: Report filed by Smoke Copilot · copilot · auto · 32.3 AIC · ⌖ 0.35 AIC · ⊞ 14.2K · ◷
Comment /smoke-copilot to run again
Add label smoke to run again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants