Closed
Strengthen tools timeout validation coverage with testify-based assertions#50387
Conversation
7 tasks
Copilot
AI
changed the title
[WIP] Improve test quality in tools_timeout_validation_test.go
Strengthen tools timeout validation coverage with testify-based assertions
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates timeout validation tests for workflow frontmatter to cover key missing
tools.startup-timeoutand negative timeout cases. It also aligns the test style with thepkg/workflowsuite’s testify assertion patterns.Expanded validation matrix for timeout fields
tools.timeoutnegative valuestools.startup-timeout: 0tools.startup-timeoutnegative valuestools.startup-timeoutinvalid non-expression string valuestools.startup-timeoutas a valid GitHub Actions expression string (${{ ... }})Assertion style modernization
t.Fatalf/t.Errorfchecks withrequire/assertto improve consistency and failure readability.Readability and intent clarity
timeoutvsstartup-timeoutbehavior.{ name: "valid startup-timeout gha expression", workflowMd: ` --- tools: startup-timeout: "${{ inputs.startup-timeout }}" --- ...`, shouldCompile: true, }