Fix duplicate C# JSON-RPC completion helper - #2735
Merged
stephentoub merged 1 commit intoSep 20, 2026
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The remaining property preserves all existing usages and resolves the duplicate-member compilation failure.
Review effort: Balanced
Findings: None
What changed in this PR
Removes the duplicate C# test helper property that caused CS0102 while preserving the existing reflection helper.
Changes:
- Deletes the redundant
JsonRpcReflection.Completiondeclaration.
| File | Description |
|---|---|
dotnet/test/Unit/JsonRpcTests.cs |
Removes the duplicate property definition. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
stephentoub
deleted the
stephentoub-investigate-runtime-allocation-failure
branch
September 20, 2026 20:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The live C# SDK build consumed by
copilot-agent-runtimefails with CS0102 because two independently merged test changes added identicalJsonRpcReflection.Completionproperties.Remove the redundant declaration while retaining the shared reflection helper used by both test sets.
Validation:
dotnet build dotnet\test\GitHub.Copilot.SDK.Test.csproj -p:CopilotSkipCliDownload=trueGenerated by Copilot