Conversation
This comment has been minimized.
This comment has been minimized.
|
@copilot I observe a failure in the net-new workflow for this PR: https://github.com/github/copilot-sdk/actions/runs/35281333643/job/105404197689?pr=2715 Please examine the workflow output, resolve the issue, and push the commits to the topic branch. I will approve the workflow. |
Root cause: |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
🟡 Changes recommended
Host validation currently treats any unknown non-glibc Linux host as musl, potentially producing mislabeled artifacts.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Java linuxmusl-x64 packaging, testing, publication, and documentation support.
Changes:
- Adds Maven profiles and native-host validation.
- Adds Alpine-based CI and publication workflows.
- Updates publication checks and documentation.
File summaries
| File | Description |
|---|---|
java/sdk/pom.xml |
Selects the musl runtime dependency. |
java/copilot-native/pom.xml |
Builds and attaches the musl classifier. |
java/copilot-native/scripts/validate-native-host.mjs |
Validates musl hosts. |
java/copilot-native/scripts/validate-native-host.test.mjs |
Tests host validation. |
java/copilot-native/scripts/fetch-native.test.mjs |
Covers musl artifact staging. |
java/copilot-native/scripts/validate-native-artifact.test.mjs |
Extends publication fixtures. |
java/copilot-native/scripts/validate-local-publication.mjs |
Requires the musl classifier. |
.github/workflows/java-sdk-tests.yml |
Adds Alpine tests and publication assembly. |
.github/workflows/java-publish-snapshot.yml |
Publishes musl snapshots. |
.github/workflows/java-publish-maven.yml |
Publishes musl releases. |
java/README.md |
Documents musl usage and building. |
java/docs/adr/adr-007-native-bundling-strategy.md |
Records musl publication support. |
Review details
- Files reviewed: 12/12 changed files
- Comments generated: 1
- Review effort level: Balanced (auto)
Note
Copilot is running an experiment and ran this review at Balanced.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
@edburns Unfortunately I hit an unexpected error while processing your comment. I've automatically reported this to GitHub. You can ask me to try again later by mentioning me in a new comment. If you want to contact GitHub about this error, please mention the following identifier so they can better serve you: Sorry for the inconvenience! |
That run (35281333643) was on The latest run on I also pushed |
The job log confirmed the missing |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
Parse the running Node executable's ELF interpreter and require the architecture-specific musl loader before packaging a musl classifier. Reject glibc, static, malformed, and otherwise unknown ELF hosts even when Node omits its glibc runtime report. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: b30bdaec-2ebd-4d51-ab1e-4de5e43772cb
4e07e4a to
1eb7948
Compare
SDK Consistency ReviewThis PR is Java-only — all 12 changed files are under What changed: Adds a Cross-SDK check: Node.js, Rust, .NET, and Python already support musl detection/packaging, and in fact already ship both Note for follow-up (non-blocking): Java still doesn't add a No inline changes requested; no other SDKs need updates for this specific change.
|
Adds Java SDK packaging, CI coverage, and publication support for the
linuxmusl-x64native runtime.Packaging
linuxmusl-x64classifier.CI
linuxmusl-x64coverage to the Java in-process test matrix.Publishing
Documentation
linuxmusl-x64#2714