Harden Rust CLI download retries - #2663
Conversation
Increase transient download retries from three to five so short GitHub release outages have a 31-second bounded backoff window in both build modes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The retry math and error classification match the stated behavior consistently in both build modes.
Review tier: Balanced (auto)
Findings: None
Note
Copilot is running an experiment and ran this review at Balanced.
What changed in this PR
Raises transient CLI download retries from three to five, extending exponential backoff to 31 seconds while preserving fail-fast handling.
Changes:
- Increased retry limits consistently across both Rust build modes.
- Clarified that the limit excludes the initial attempt.
| File | Description |
|---|---|
rust/build/out_of_process.rs |
Raises out-of-process download retries to five. |
rust/build/in_process.rs |
Raises in-process download retries to five. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ArshVermaGit
left a comment
ArshVermaGit
left a comment
There was a problem hiding this comment.
Looks good to me. The retry count is updated consistently for both in-process and out-of-process builds, and the existing fail-fast behavior for non-transient errors is preserved. The checks are passing as well. No issues from my side.
Summary
Fixes the transient download failure observed in github/github-app CI run 34929070862.
Validation
cd rust && cargo +nightly-2026-04-14 fmt --checkcd rust && cargo clippy --all-features --all-targets -- -D warningscd rust && cargo test --all-features --lib(248 passed)cd rust && cargo test --all-featuresreached the E2E target; 371 E2E tests could not initialize becausetsxis not installed in the local workspace (sh: tsx: command not found)