Skip to content

Use dependency groups for Python dev deps #2038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
brettcannon wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

Use dependency groups for Python dev deps #2038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/copilot-instructions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
- Format all: `just format` | Lint all: `just lint` | Test all: `just test`
- Per-language:
- Node: `cd nodejs && npm ci` → `npm test` (Vitest), `npm run generate:session-types` to regenerate session-event types
- Python: `cd python && uv pip install -e ".[dev]"` → `uv run pytest` (E2E tests use the test harness)
- Python: `cd python && uv pip install -e . --group dev` → `uv run pytest` (E2E tests use the test harness)
- Go: `cd go && go test ./...`
- .NET: `cd dotnet && dotnet test test/GitHub.Copilot.SDK.Test.csproj`
- **.NET testing note:** Never add `InternalsVisibleTo` to any project file when writing tests. Tests must only access public APIs.
Expand Down
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ This is a multi-language SDK repository. Install the tools for the SDK(s) you pl

1. Install [Python 3.8+](https://www.python.org/downloads/)
1. Install [uv](https://github.com/astral-sh/uv)
1. Install dependencies: `cd python && uv pip install -e ".[dev]"`
1. Install dependencies: `cd python && uv pip install -e . --group dev`

### Go SDK

Expand Down
2 changes: 1 addition & 1 deletion justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ install-go: install-nodejs install-test-harness
# Install Python dependencies and prerequisites for tests
install-python: install-nodejs install-test-harness
@echo "=== Installing Python dependencies ==="
@cd python && uv pip install -e ".[dev]"
@cd python && uv pip install -e . --group dev

# Install .NET dependencies and prerequisites for tests
install-dotnet: install-nodejs install-test-harness
Expand Down
8 changes: 5 additions & 3 deletions python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,11 @@ Homepage = "https://github.com/github/copilot-sdk"
Repository = "https://github.com/github/copilot-sdk"

[project.optional-dependencies]
telemetry = [
"opentelemetry-api>=1.0.0",
]

[dependency-groups]
dev = [
"ruff>=0.1.0",
"ty>=0.0.2,<0.0.25",
Expand All @@ -44,9 +49,6 @@ dev = [
"websockets>=12.0",
"opentelemetry-sdk>=1.0.0",
]
telemetry = [
"opentelemetry-api>=1.0.0",
]

[tool.setuptools.packages.find]
where = ["."]
Expand Down
Loading