Merged
Conversation
hvitved
changed the title
hvitved
force-pushed
the
shared/remove-deprecated
branch
from
0243267 to
61f1ef8
Compare
Contributor
Author
Rerun has been triggered: 3 restarted 🚀 |
jketema
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes a set of deprecated SSA, dataflow, and control-flow compatibility APIs across shared and language-specific libraries (Swift/Ruby/C#), continuing the cleanup of legacy predicates/classes in the CodeQL standard libraries.
Changes:
- Removed deprecated SSA helper predicates/types (including old “last read/last ref” helpers and legacy SSA-reaching modules/aliases).
- Removed deprecated
hasLocationInfoforwarding predicates from shared dataflow node wrappers, and removed deprecated source/sink grouping APIs. - Removed deprecated control-flow tree child-accessor helpers.
Show a summary per file
| File | Description |
|---|---|
| swift/ql/lib/codeql/swift/dataflow/Ssa.qll | Removes deprecated SSA predicate wrapper. |
| shared/ssa/codeql/ssa/Ssa.qll | Deletes large block of deprecated SSA reachability APIs; consolidates on the non-deprecated module/types. |
| shared/dataflow/codeql/dataflow/internal/DataFlowImplStage1.qll | Removes deprecated hasLocationInfo forwarding predicate. |
| shared/dataflow/codeql/dataflow/internal/DataFlowImplCommon.qll | Removes deprecated FlowStateString helper module. |
| shared/dataflow/codeql/dataflow/internal/DataFlowImpl.qll | Removes deprecated hasLocationInfo forwarding and deprecated source/sink grouping predicates. |
| shared/dataflow/codeql/dataflow/DataFlow.qll | Removes deprecated hasLocationInfo forwarding predicates from public DataFlow node types. |
| shared/controlflow/codeql/controlflow/Cfg.qll | Removes deprecated child accessor helpers on control-flow tree nodes. |
| ruby/ql/lib/codeql/ruby/dataflow/internal/SsaImpl.qll | Removes deprecated “last read” implementation helpers. |
| ruby/ql/lib/codeql/ruby/dataflow/SSA.qll | Removes deprecated getALastRead API. |
| csharp/ql/lib/semmle/code/csharp/dataflow/internal/SsaImpl.qll | Removes deprecated “last read” implementation helpers. |
| csharp/ql/lib/semmle/code/csharp/dataflow/SSA.qll | Removes deprecated getALastRead / getALastReadAtNode APIs. |
Copilot's findings
- Files reviewed: 11/11 changed files
- Comments generated: 0
aschackmull
approved these changes
Apr 23, 2026
Contributor
aschackmull
left a comment
aschackmull
left a comment
There was a problem hiding this comment.
Excellent, go go merge. 🚀 (LGTM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.