Go: refactor EncryptionOperation#21745
Merged
owen-mc merged 1 commit intogithub:mainfrom Apr 22, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors Go QL cryptography modeling by changing EncryptionOperation to use abstract accessor methods for its key data-flow nodes, and updating existing implementations to follow the new pattern.
Changes:
- Replace
EncryptionOperation’s storedencryptionFlowTarget/inputNodefields with abstract methodsgetEncryptionFlowTarget()andgetInputNode(). - Update
EncryptionMethodCallto implement these accessors and adjust its constructor to only constrain required nodes’ existence. - Update
crypto/cipherStreamReaderandStreamWritermodels to store necessary nodes locally and implement the new accessors.
Show a summary per file
| File | Description |
|---|---|
| go/ql/lib/semmle/go/frameworks/CryptoLibraries.qll | Updates StreamReader/StreamWriter implementations to override the new EncryptionOperation accessors. |
| go/ql/lib/semmle/go/Concepts.qll | Refactors EncryptionOperation to require accessors and updates EncryptionMethodCall accordingly. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 0
Co-authored-by: Copilot <copilot@github.com>
owen-mc
force-pushed
the
go/refactor-encryption-operation
branch
from
677dbcb to
57eaed4
Compare
Contributor
Author
|
DCA was uneventful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.