Align @eslint/js with ESLint 9 and pin the pair in Dependabot config - #1458
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mbg
approved these changes
Aug 4, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Aligns @eslint/js with ESLint 9 and regenerates the dependency graph.
Changes:
- Pins both ESLint packages to
^9.39.5. - Deduplicates
@eslint/jsin the lockfile. - Groups future Dependabot updates, though major updates can still become misaligned.
Show a summary per file
| File | Description |
|---|---|
package.json |
Aligns the direct dependency version. |
package-lock.json |
Regenerates the peer-clean dependency graph. |
.github/dependabot.yml |
Groups ESLint dependency updates. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Balanced
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
mbg
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@eslint/jsrange from^10.0.1to the latest 9.x,^9.39.5, while keepingeslintat^9.39.5@eslint/js@9.39.5eslintand@eslint/jseslintand@eslint/jsupdates for when both packages are unpinned; minor and patch updates remain in the existingnpm-minorgroupThis supersedes closed #1456 and is based directly on
mainwithout reusing that branch or history.Context
The
@eslint/js@^10.0.1/eslint@^9.39.5peer mismatch made clean lockfile regeneration impossible, while the frozen lockfile used bynpm cikept passing and hid the mismatch for roughly six weeks. #1372 merged@eslint/js10.0.1 on June 22, 2026. #1424, which proposed ESLint 10.5.0, closed on June 23 after@dependabot ignore this major version, leaving only half of the pair upgraded.ESLint 10 is deferred purely because
eslint-plugin-githubtransitively depends oneslint-plugin-importandeslint-plugin-jsx-a11y, whose peer ranges exclude it.eslint-plugin-import@2.32.0allows^2 || ^3 || ^4 || ^5 || ^6 || ^7.2.0 || ^8 || ^9;eslint-plugin-jsx-a11y@6.10.2allows^3 || ^4 || ^5 || ^6 || ^7 || ^8 || ^9. npm can install ESLint 10 only by overriding those peers, andnpm lsmarkseslint@10.8.0invalid.This is not migration debt in this repository: the ESLint 10.8.0 investigation required no source or lint-configuration changes, produced zero lint violations, and passed all 44 tests. However,
npm ci --dry-run --strict-peer-depsfails ERESOLVE immediately oneslint-plugin-import's range. The ESLint 10 route therefore breaks outright for strict-peer-deps users and remains exposed to any future npm default change; alignment is required for an honestly resolvable graph.Registry inspection found no imminent support signal.
eslint-plugin-importlatest is 2.32.0 and itsnexttag is an obsolete 2.0 beta;eslint-plugin-jsx-a11ylatest is 6.10.2 with no relevant prerelease; andeslint-plugin-githublatest is 6.1.2, still depending on@eslint/js@^9.39.5,eslint-plugin-import@^2.31.0, andeslint-plugin-jsx-a11y@^6.10.2with no relevantnextrelease.Dependabot guard
The
eslintignore previously existed only in invisible server-side Dependabot state. Dependabot reports that hidden condition exactly as[>= 10.a, < 11], so it covers ESLint 10.x only, not all future majors.The declarative semver-major ignores in this PR are intentionally broader and symmetric. Without the declarative
eslintrule, the 10-only server pin plus an all-major@eslint/jspin could eventually alloweslint@11while@eslint/jsremained frozen, mirroring the same half-upgrade trap. Both declarative ignores must be lifted together, and only onceeslint-plugin-importandeslint-plugin-jsx-a11ysupport ESLint 10 througheslint-plugin-github; lifting only one recreates the mismatch.GitHub's Dependabot options reference states that a dependency matching multiple groups is included in the first group it matches. The specific
eslintgroup is therefore declared before the wildcardnpm-minorgroup and covers major updates only. Minor and patch updates fall through tonpm-minor. The ignores hold the line now; the dedicated group will pair eligible major updates once both packages are unpinned.Validation
9.39.5is the latest@eslint/js9.xnpm installwithout force/legacy flags or ERESOLVE peer override warningsnpm cinpm lswith@eslint/js@9.39.5deduplicated across ESLint andeslint-plugin-githubnpm run-script lint.github/workflows/script/check-js.sh.github/workflows/script/check-json-schemas.shnpm run-script find-deadcode