Skip to content

docs: restructure Foundry lessons to match workshop patterns (VS Code harness) - #183

Open
GeekTrainer wants to merge 3 commits into
vscode-foundry-agentfrom
geektrainer/vscode-foundry-workshop-patterns
Open

GeekTrainer wants to merge 3 commits into
vscode-foundry-agentfrom
geektrainer/vscode-foundry-workshop-patterns

Conversation

@GeekTrainer

Copy link
Copy Markdown
Collaborator

Summary

Stacked follow-up to #178, targeting vscode-foundry-agent: restructure the optional VS Code Foundry exercise into an overview and three focused modules that follow the workshop's scenario, guided-work, verification, and checkpoint patterns. Preserve #178 as the lower layer, not a replacement or superseded PR; the required harness still ends independently after Exercise 6.

Type of change

  • Workshop content (lesson Markdown, images)
  • Site shell (website/ Astro + Starlight wrapper)
  • Copilot configuration (.github/copilot-instructions.md, instructions, agents, skills)
  • Repo housekeeping (CI, dependabot, README, license)
  • Other:

Verification

  • Type checks and a clean site build pass.
  • Affected pages and translations match their source and intended routes.
  • Offline internal link checks pass.
  • Changed external links have been checked separately. N/A: external destination URLs are unchanged.

Verification was completed immediately before transfer in the original source worktree on the identical source tree. This layer started at #178's exact head, 346b262621ef1c13ea050db407eb9606cb97fe99; every one of the 40 transferred paths was checked against the supplied SHA256/deletion manifest before committing. No content changes or dependency installation occurred during transfer.

  • The required verify.sh sequence passed: check:all (Astro: 0 errors, 0 warnings, 4 deprecation hints; tsgo passed), clean build (242 generated pages), and offline Lychee (20,672 total links, 2,922 unique, 0 errors).
  • Source/output inspection covered all 36 affected English/localized pages, including routes, anchors, ordered steps, images, inline code, fenced blocks, and cleanup links. All 16 original fenced blocks and eight referenced images were preserved. The source checker was rerun after transfer: 175 source routes, 36 affected pages, 0 errors; git diff --check passed.
  • Translation review passed for all five locales: Spanish, Japanese, Korean, Brazilian Portuguese, and Simplified Chinese. Each includes the four optional pages, harness overview, and core Exercise 6.
  • Browser QA on the identical source tree covered all 36 affected routes plus five representative routes: HTTP 200, correct titles/languages, no console/page errors, no broken images, and no raw admonition markers. All six language sidebar groups, module labels, and localized cleanup anchors were checked. This browser QA description serves in place of new screenshots.
  • Content alignment and structural consistency were reviewed, including the renamed overview route, localized navigation, independent required-harness ending, and minimal authoring/root README updates.

Notes for reviewers

Review this layer against #178, not main. The original PR's title, body, and head remain unchanged; no merge is requested.

The extension uses one learner repository, branch, Foundry project, and model throughout. It retains the Foundry Toolkit wizard, GitHub Issues attachment, AIAgentExpert, Agent Inspector/F5, Go production handoff, Hosted Playground, regular Agent mode, and /clear. Shared cleanup covers stopping after only project/model creation or after hosted deployment, with explicit ownership checks and a prohibition on deleting shared resource groups. The site proxy remains local-development-only. No cloud resources were provisioned.

Inherited dependency warning: the user-approved npm ci in the source worktree reported eight vulnerabilities in the unchanged lockfile (one moderate, six high, one critical). These were not introduced by this documentation change; dependency manifests and lockfiles are unchanged, and dependency remediation is outside this PR. GitHub also reported 15 existing default-branch dependency alerts during push (one critical, 12 high, two moderate), a separate repository-level count.

… harness)

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@GeekTrainer
GeekTrainer added this pull request to stack #184 September 16, 2026 17:35
juliamuiruri4 and others added 2 commits September 17, 2026 15:04
Match the sidebar convention used by every other harness group, where
the first child is a plain Overview link rather than a repeat of the
group label.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Rework the optional extension so learners can tell where they are and
what carries forward between modules.

- Rename "Choose a starting point" to "Before you begin" and make the
  resume step concrete: reopen the branch and confirm the project and
  model deployment still exist.
- Drop the redundant subscription and cost review step; that guidance
  already sits where resources are approved, in modules 1 and 2.
- Rewrite cleanup as explicit azd and az steps, identifying the agent
  directory by the azure.yaml it contains.
- Replace the numbered completion checkpoints with two short paragraphs
  naming the checkpoint and what the next module reuses.
- Close the final module on the VS Code overview.

Applied to English and all five localized copies.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI lite review requested due to automatic review settings September 17, 2026 12:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Six localized and English project/model modules contain a blocking branch-resume command issue.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 6 Medium severity · 1 Low severity

Open (7)
What changed in this PR

Restructures the optional VS Code Foundry exercise into an overview and three focused modules, preserving Exercise 6 as the required endpoint.

Changes:

  • Adds English and five localized Foundry lesson modules.
  • Updates navigation, documentation indexes, and authoring guidance.
  • Removes the former monolithic Foundry lesson.

Review findings:

  • Six project/model modules require branch-resume handling before approval (moderate, 2 votes each).
  • The localized sidebar overview label is missing (nit, 2 votes).
File Description
website/​astro.config.mjs Adds nested Foundry navigation; localized overview label is missing.
README.md Updates repository documentation.
docs/​zh-cn/​vscode/​README.md Adds Chinese VS Code overview.
docs/​zh-cn/​vscode/​7-foundry-toolkit/​README.md Adds Chinese Foundry overview.
docs/​zh-cn/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds Chinese site-integration module.
docs/​zh-cn/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds Chinese deployment module.
docs/​zh-cn/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds Chinese project/model module; branch-resume handling needs changes.
docs/​zh-cn/​vscode/​6-iterating.md Localizes the required Exercise 6 endpoint.
docs/​vscode/​README.md Updates the Foundry overview entry.
docs/​vscode/​7-foundry-toolkit/​README.md Adds English Foundry overview.
docs/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds English site-integration module.
docs/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds English deployment module.
docs/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds English project/model module; branch-resume handling needs changes.
docs/​vscode/​7-foundry-toolkit.md Removes the monolithic Foundry lesson.
docs/​vscode/​6-iterating.md Makes Exercise 6 the required endpoint.
docs/​pt-br/​vscode/​README.md Adds Portuguese VS Code overview.
docs/​pt-br/​vscode/​7-foundry-toolkit/​README.md Adds Portuguese Foundry overview.
docs/​pt-br/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds Portuguese site-integration module.
docs/​pt-br/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds Portuguese deployment module.
docs/​pt-br/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds Portuguese project/model module; branch-resume handling needs changes.
docs/​pt-br/​vscode/​6-iterating.md Localizes the required Exercise 6 endpoint.
docs/​ko-kr/​vscode/​README.md Adds Korean VS Code overview.
docs/​ko-kr/​vscode/​7-foundry-toolkit/​README.md Adds Korean Foundry overview.
docs/​ko-kr/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds Korean site-integration module.
docs/​ko-kr/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds Korean deployment module.
docs/​ko-kr/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds Korean project/model module; branch-resume handling needs changes.
docs/​ko-kr/​vscode/​6-iterating.md Localizes the required Exercise 6 endpoint.
docs/​ja-jp/​vscode/​README.md Adds Japanese VS Code overview.
docs/​ja-jp/​vscode/​7-foundry-toolkit/​README.md Adds Japanese Foundry overview.
docs/​ja-jp/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds Japanese site-integration module.
docs/​ja-jp/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds Japanese deployment module.
docs/​ja-jp/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds Japanese project/model module; branch-resume handling needs changes.
docs/​ja-jp/​vscode/​6-iterating.md Localizes the required Exercise 6 endpoint.
docs/​es-es/​vscode/​README.md Adds Spanish VS Code overview.
docs/​es-es/​vscode/​7-foundry-toolkit/​README.md Adds Spanish Foundry overview.
docs/​es-es/​vscode/​7-foundry-toolkit/​3-connect-to-site.md Adds Spanish site-integration module.
docs/​es-es/​vscode/​7-foundry-toolkit/​2-build-and-deploy.md Adds Spanish deployment module.
docs/​es-es/​vscode/​7-foundry-toolkit/​1-project-and-model.md Adds Spanish project/model module; branch-resume handling needs changes.
docs/​es-es/​vscode/​6-iterating.md Localizes the required Exercise 6 endpoint.
AUTHORING.md Documents the nested lesson structure.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment on lines +36 to +39
```bash
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment on lines +36 to +39
```bash
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment on lines +37 to +39
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment on lines +36 to +39
```bash
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment on lines +37 to +39
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment on lines +36 to +39
```bash
git checkout main
git pull
git checkout -b foundry-agent-vscode
Comment thread website/astro.config.mjs
'zh-CN': '可选:集成 Foundry',
},
items: [
{ label: 'Overview', link: '/vscode/7-foundry-toolkit/' },
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants