Skip to content

docs: refresh App workshop with learner-created skills and QA - #172

Merged
GeekTrainer merged 0 commit into
geektrainer/cli-workshop-prfrom
geektrainer/app-workshop-pr
Sep 14, 2026
Merged

GeekTrainer merged 0 commit into
geektrainer/cli-workshop-prfrom
geektrainer/app-workshop-pr

Conversation

@GeekTrainer

Copy link
Copy Markdown
Collaborator

Summary

Final layer 4/4, based on #171 (geektrainer/cli-workshop-pr), of the replacement stack for #167. Mechanically transfers the reviewed App workshop and five translations from pinned revision e150fd531805f57a77be754c37f342386471bc00: setup, star ratings, instructions, filtering, learner-created quality-checks skill, MCP, QA, feature merge, repository-backed canvas, and recap.

Only App directories and eight shared files change: the AUTHORING structure-tree line, App description in six landing pages, and App sidebar. The cumulative tree is exactly 9a355f98d21b9b7a5bd9e0e6b71c691cfd1b36c7, identical to the pinned final snapshot. #167 remains untouched and retains the detailed review and trial history.

Type of change

  • Workshop content (lesson Markdown, images)
  • Site shell (website/ Astro + Starlight wrapper)
  • Copilot configuration (.github/copilot-instructions.md, instructions, agents, skills)
  • Repo housekeeping (CI, dependabot, README, license)
  • Other:

Verification

  • Type checks and a clean site build pass.
  • Affected pages and translations match their source and intended routes.
  • Offline internal link checks pass.
  • Changed external links have been checked separately.

Fresh check:all and build ran from this worktree using the existing matching locked dependencies through a temporary ignored symlink; no installs, and the symlink was removed. Checks report zero errors/warnings and four existing Astro deprecation hints. Offline lychee: zero errors. Source-derived inspection covered 78 affected App/landing routes across six configured languages, their titles/headings, 1,752 paragraphs, and 168 rendered fences; all 24 removed routes are absent. The four frozen English skill/QA prompt hashes match, skill CREATE remains 184 words, and corresponding CLI/App prompts align across locales. All App source bytes and translated fences match the pinned revision. Four added external skill links returned HTTP 200; stale-route and content-alignment sweeps found no remaining drift.

Notes for reviewers

Depends on the lower stack (#169, #170, #171) and external template work github-samples/tailspin-toys#97 and github-samples/tailspin-toys#91; no template changes or merges are included. The raw partition is 104 paths without rename detection (102 with Git's detected renames), all within the authorized scope.

Historical Bash/macOS skill trials with Sonnet and MAI passed lint, unit tests (35 tests/3 files), E2E (28 tests/4 specs), type checks, and the single-file test (12 tests/1 file); see #167 for details. These are not fresh App QA/UI certification. Sonnet recovered from read-only denials, and outer pipeline exit 0 was not native-exit proof; MAI recovered a denied outer eval loop with five direct successful calls, and eval was absent from its generated wrappers. Native PowerShell, the broader QA matrix, App agent-picker/hot discovery, and a full UI rehearsal remain unverified; no new trials or runtime/UI checks were performed here.

Existing rendered callout bodies remain plain divs rather than styled asides, with no raw admonition markers. Renderer, loader, and dependencies are unchanged; that caveat is intentionally not fixed in this mechanical partition. Keep this PR draft; stack registration and disposition of #167 are left to the coordinating session.

@GeekTrainer

Copy link
Copy Markdown
Collaborator Author

Replacement App review: #174, directly above #169. Current native stack review order is #169#174#170#171.

GitHub indirectly marked this PR merged when its then-current CLI base acquired the App commit during reordering. Nothing merged into main. This closed PR and its original stack remain preserved as history; use #174 for ongoing App review. The final reordered stack tree exactly matches the preserved complete revision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant