Repository navigation
fix(ssm): restore incremental housekeeper cleanup - #5508
Merged
Merged
Conversation
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Brend-Smits
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5477 (
445269c) unintentionally reverted #5464: the SSM housekeeper again lists every parameter before deleting anything, loses candidates when the first page omitsParameters, and has no remaining-runtime guard. A late listing failure or timeout can therefore prevent cleanup from making progress.Reapply #5464 unchanged on current main, restoring page-by-page deletion, pagination through empty pages, isolated deletion failures, the ten-second runtime guard and its Lambda wiring, tests, and README notes. The restored patch has the same stable patch ID as #5464.
#5469 already includes an equivalent restoration commit (
762583d). This PR separates that restoration from the batching changes so it can land independently. Once merged, #5469 can rebase and drop its duplicate restoration commit.Validation: 127 storage-provider tests and 22 Lambda wrapper tests passed. ESLint and Prettier passed for the changed TypeScript files; the control-plane Lambda bundle build and
git diff --checkpassed. No AWS deployment or live parameter deletion was performed.