Repository navigation
Conversation
…ourse Course points (the injected Start/End/interval points and the GPX waypoints) were all written before the first record. They are now written right after the record at their distance along the course, as Garmin's EncodeCourse example does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Course points used to be written all at once, before the first record. Now each one is written right after the record at its distance along the course, the way Garmin's EncodeCourse.java example does it.
cp_min_dist) and the GPX waypoints fromwriteWayPoints. The way course points are picked is unchanged.pt_min_distskipped goes after the last record written. Any left over go after the last record, before the stop event.getDistance(), so both values get the SDK's centimetre rounding. Comparing against the raw double failed both ways.TestCourseFit.coursePointsFollowTheirRecorddecodes the file and checks that every course point comes right after a record with the same distance and timestamp. It fails on master.This changes what devices receive. It needs testing on a real Garmin device before merging (course points in "Up Ahead", Start/End, waypoint alerts).
🤖 Generated with Claude Code